Issue 7020 - publish gecko with Node.js

automation/build.js

 /*

[tlucas, 2018/10/04 15:27:07]

For some reason, rietveld recognized this as a change for ext/devtools.js -> In
a `git show` it's clearly a new file:

index 0000000..983f065
--- /dev/null
+++ b/automation/build.js
@@ -0,0 +1,26 @@
+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,

...

[Sebastian Noack, 2018/10/04 19:56:52]

Welcome to Git! There is no information like file movement in the internal data
structures of Git (unlike Mercurial). Commands like "git diff" just try to be
smarter than you and guess what file has been moved where. Though, it's arguably
weird that it does so if ext/devtools.js still exists.

  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+/* eslint-env node */

[Sebastian Noack, 2018/10/04 19:56:52]

If we put these scripts into a separate directory we might rather add an
.eslintrc.json (similar to the on we have in the "test" directory).

[tlucas, 2018/10/15 10:26:19]

Done.

+
 "use strict";
 
-{
-  let inspectedTabId = browser.devtools.inspectedWindow.tabId;
-  let port = browser.runtime.connect({name: "devtools-" + inspectedTabId});
+const path = require("path");
 
-  ext.onMessage = port.onMessage;
-  ext.devtools = browser.devtools;
-}
+let platform = process.argv[2];

[Sebastian Noack, 2018/10/04 19:56:52]

This temporary variable seems unnecessary. You could inline process.argv[2]
below within the template string.

[tlucas, 2018/10/15 10:26:19]

Not relevant anymore.

+
+require(path.resolve(`automation/builds/${platform}`));