Issue 6493 - Ensure Firefox draws the "Block element" popup window

lib/filterComposer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 174 matching lines @@
       }).then(response =>
       {
         // Sometimes sendMessage incorrectly reports a success on Firefox, so
         // we must check the response too.
         if (!response)
           throw new Error();
 
         // Sometimes Firefox doesn't draw the window's contents initially, so we
         // resize the window slightly as a workaround.
         // https://issues.adblockplus.org/ticket/6493
-        browser.windows.update(window.id, {width: 422});

[kzar, 2018/10/04 15:30:37]

For some reason one pixel larger wasn't enough to have Firefox redraw the
window, so I had to go with 422px.

[Sebastian Noack, 2018/10/04 18:38:55]

Would it work if we remove the width from the browser.windows.create() call, and
then resize it to the correct width here? That way we would define the width
only in one place, and we don't have to set it to a weird number like 422.

[kzar, 2018/10/08 14:50:13]

Well, I tried that but initially the width of the popup was much larger, then it
shrunk down. It looked kind of janky! 

How about this instead? I avoid hard-coding the width again, instead just add
2px (the minimum required).

+        if (info.application == "firefox")
+          browser.windows.update(window.id, {width: window.width + 2});
       }).catch(e =>
       {
         // Firefox sometimes sets the status for a window to "complete" before
         // it is ready to receive messages[1]. As a workaround we'll try again a
         // few times with a second delay.
         // [1] - https://bugzilla.mozilla.org/show_bug.cgi?id=1418655
         setTimeout(doInit, 100);
       });
     };
     if (window.tabs[0].status != "complete")
@@ skipping 157 matching lines @@
 port.on("composer.isPageReady", (message, sender) =>
 {
   return readyActivePages.has(new ext.Page({id: message.pageId}));
 });
 
 port.on("composer.ready", (message, sender) =>
 {
   readyActivePages.set(sender.page, !checkWhitelisted(sender.page));
   updateContextMenu(sender.page);
 });