Issue 6493 - Ensure Firefox draws the "Block element" popup window

lib/filterComposer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 174 matching lines @@
       }).then(response =>
       {
         // Sometimes sendMessage incorrectly reports a success on Firefox, so
         // we must check the response too.
         if (!response)
           throw new Error();
 
         // Sometimes Firefox doesn't draw the window's contents initially, so we
         // resize the window slightly as a workaround.
         // https://issues.adblockplus.org/ticket/6493
-        browser.windows.update(window.id, {width: window.width + 2});

[Sebastian Noack, 2018/10/08 15:11:53]

Still the window ends up 2 pixels larger as it meant to be. how about this:

  const WINDOW_WITH = 420;
  ...
  browser.window.create({..., width: WINDWOW_WIDTH - 2}, ...);
  ...
  browser.window.update(window.id, {width: WINDOW_WIDTH});

[kzar, 2018/10/08 15:58:28]

Well, I guess so, but I really don't think that matters. This approach also has
the advantage that the workaround is in one place, so easier to remove in the
future.

[Sebastian Noack, 2018/10/08 16:07:22]

I think this workaround should not change the effective size if not necessary.

[kzar, 2018/10/08 17:23:15]

Done.

+        if (info.application == "firefox")
+          browser.windows.update(window.id, {width: window.width + 2});
       }).catch(e =>
       {
         // Firefox sometimes sets the status for a window to "complete" before
         // it is ready to receive messages[1]. As a workaround we'll try again a
         // few times with a second delay.
         // [1] - https://bugzilla.mozilla.org/show_bug.cgi?id=1418655
         setTimeout(doInit, 100);
       });
     };
     if (window.tabs[0].status != "complete")
@@ skipping 157 matching lines @@
 port.on("composer.isPageReady", (message, sender) =>
 {
   return readyActivePages.has(new ext.Page({id: message.pageId}));
 });
 
 port.on("composer.ready", (message, sender) =>
 {
   readyActivePages.set(sender.page, !checkWhitelisted(sender.page));
   updateContextMenu(sender.page);
 });