Issue 6493 - Ensure Firefox draws the "Block element" popup window

lib/filterComposer.js

Index: lib/filterComposer.js
diff --git a/lib/filterComposer.js b/lib/filterComposer.js
index fe5dcdf3071e1762e31cfb4e4bd461a67bbcac23..6e48bd48385f1f1748997ff7ceaac1ee0814d9a0 100644
--- a/lib/filterComposer.js
+++ b/lib/filterComposer.js
@@ -188,6 +188,11 @@ port.on("composer.openDialog", (message, sender) =>
         // we must check the response too.
         if (!response)
           throw new Error();
+
+        // Sometimes Firefox doesn't draw the window's contents initially, so we
+        // resize the window slightly as a workaround.
+        // https://issues.adblockplus.org/ticket/6493
+        browser.windows.update(window.id, {width: window.width + 2});

[Sebastian Noack, 2018/10/08 15:11:53]

Still the window ends up 2 pixels larger as it meant to be. how about this:

  const WINDOW_WITH = 420;
  ...
  browser.window.create({..., width: WINDWOW_WIDTH - 2}, ...);
  ...
  browser.window.update(window.id, {width: WINDOW_WIDTH});

[kzar, 2018/10/08 15:58:28]

Well, I guess so, but I really don't think that matters. This approach also has
the advantage that the workaround is in one place, so easier to remove in the
future.

[Sebastian Noack, 2018/10/08 16:07:22]

I think this workaround should not change the effective size if not necessary.

[kzar, 2018/10/08 17:23:15]

Done.

       }).catch(e =>
       {
         // Firefox sometimes sets the status for a window to "complete" before