Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(963)

Issue 29904564: Issue 6682 - Automated builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by tlucas
Modified:
1 year, 1 month ago
Reviewers:
Sebastian Noack, wspee
CC:
sergei, kzar
Visibility:
Public.

Description

Issue 6682: Automated builds Actual commit messages: Issue 6682 - Create builds through CI Issue 6682 - Update buildtools to 59a519c38766 / 9342139 Pipeline for master, with builds: https://gitlab.com/triluc/adblockpluschrome/pipelines/32309636 Pipeline for a random branch, without builds: https://gitlab.com/triluc/adblockpluschrome/pipelines/32309646

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M .gitlab-ci.yml View 1 3 chunks +37 lines, -3 lines 0 comments Download
M dependencies View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
tlucas
Patch Set 1: * Update buildtools dependency * Add 'build:{gecko|chrome|edge}'-jobs to CI
1 year, 1 month ago (2018-10-08 14:51:32 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29904564/diff/29904565/.gitlab-ci.yml File .gitlab-ci.yml (right): https://codereview.adblockplus.org/29904564/diff/29904565/.gitlab-ci.yml#newcode58 .gitlab-ci.yml:58: - ./*.appx Perhaps we should make the filename a ...
1 year, 1 month ago (2018-10-08 15:16:55 UTC) #2
tlucas
Patch Set 2: * Address Sebastian comments. New pipelines: https://gitlab.com/triluc/adblockpluschrome/pipelines/32316067 (master) https://gitlab.com/triluc/adblockpluschrome/pipelines/32316008 (arbitrary) https://codereview.adblockplus.org/29904564/diff/29904565/.gitlab-ci.yml File ...
1 year, 1 month ago (2018-10-08 15:39:13 UTC) #3
Sebastian Noack
LGTM
1 year, 1 month ago (2018-10-08 15:43:06 UTC) #4
wspee
1 year, 1 month ago (2018-10-08 15:48:47 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5