dependencies - Issue 29907589: Issue 7054 - Update the adblockpluscore dependency to 5cb695da5a40, adblockplusui to f86abf2efdfd

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: dependencies

Issue 29907589: Issue 7054 - Update the adblockpluscore dependency to 5cb695da5a40, adblockplusui to f86abf2efdfd (Closed)

Left Patch Set: Address PS7 comment Created Dec. 17, 2018, 7:38 p.m.

Right Patch Set: Address PS12 Comment Created Jan. 8, 2019, 1:02 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:ff1b7ee78ebd git:5115e5a	3 buildtools = buildtools hg:33f115e8c1b3 git:f02a6f2

4 adblockpluscore = adblockpluscore hg:fac3c11b26e2 git:466bc32	4 adblockpluscore = adblockpluscore hg:5cb695da5a40 git:b6ef032
kzar 2018/12/18 11:29:56 This is now the correct Mercurial revision, but th This is now the correct Mercurial revision, but the Git revision is out of date. Please can you update that as well? Jon Sonesen 2018/12/19 10:05:20 Done. Show quoted text On 2018/12/18 11:29:56, kzar wrote: > This is now the correct Mercurial revision, but the Git revision is out of date. > Please can you update that as well? Done.
5 adblockplusui = adblockplusui hg:f86abf2efdfd git:1660877	5 adblockplusui = adblockplusui hg:f86abf2efdfd git:1660877

LEFT	RIGHT