Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/filterComposer.js

Issue 29907589: Issue 7054 - Update the adblockpluscore dependency to 5cb695da5a40, adblockplusui to f86abf2efdfd (Closed)
Patch Set: Address PS12 Comment Created Jan. 8, 2019, 1:02 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/devtools.js ('k') | lib/firefoxDataCleanup.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/filterComposer.js
===================================================================
--- a/lib/filterComposer.js
+++ b/lib/filterComposer.js
@@ -86,23 +86,23 @@
let docDomain = extractHostFromFrame(frame);
let specificOnly = checkWhitelisted(page, frame, null,
RegExpFilter.typeMap.GENERICBLOCK);
// Add a blocking filter for each URL of the element that can be blocked
for (let url of details.urls)
{
let urlObj = new URL(url, details.baseURL);
- let filter = defaultMatcher.whitelist.matchesAny(
+ let whitelisted = defaultMatcher.isWhitelisted(
urlObj.href, typeMask, docDomain,
isThirdParty(urlObj, docDomain),
getKey(page, frame), specificOnly
);
- if (!filter)
+ if (!whitelisted)
{
let filterText = urlObj.href.replace(/^[\w-]+:\/+(?:www\.)?/, "||");
if (specificOnly)
filterText += "$domain=" + docDomain;
if (!filters.includes(filterText))
filters.push(filterText);
« no previous file with comments | « lib/devtools.js ('k') | lib/firefoxDataCleanup.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld