Issue 29908581: Issue #7036 - [XTM Integration] Add support for providing workflow name

Issue 29908581: Issue #7036 - [XTM Integration] Add support for providing workflow name (Closed)

Created:
Oct. 12, 2018, 2:03 p.m. by Tudor Avram

Modified:
Oct. 29, 2018, 10:44 a.m.

Reviewers:
Vasily Kuznetsov

CC:
wspee

Visibility:
Public.

Description

Issue #7036 - [XTM Integration] Add support for providing workflow name

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments from Patch Set 1 #

Total comments: 1

Created: Oct. 18, 2018, 4:23 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -49 lines)			Patch
M	.gitignore	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	.hgignore	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	cms/translations/xtm/cli.py	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	cms/translations/xtm/constants.py	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	cms/translations/xtm/projects_handler.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	cms/translations/xtm/utils.py	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
M	cms/translations/xtm/xtm_api.py	View	1	3 chunks	+31 lines, -0 lines	0 comments	Download
M	tests/test_xtm_api.py	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	tests/test_xtm_translate.py	View	1	4 chunks	+8 lines, -38 lines	0 comments	Download
M	tests/test_xtm_translations_utils.py	View	1	5 chunks	+31 lines, -5 lines	0 comments	Download
M	tests/utils.py	View	1	2 chunks	+47 lines, -0 lines	1 comment	Download
M	tests/xtm_mock_api.py	View		2 chunks	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Tudor Avram

Hi Vasily, Here is my code that gives users the possibility to provide the workflow ...

Oct. 12, 2018, 2:05 p.m. (2018-10-12 14:05:36 UTC) #1

Tudor Avram

Hi Vasily, I just realised that I put the wrong handler here (`kvas`), so wasn't ...

Oct. 16, 2018, 11:53 a.m. (2018-10-16 11:53:53 UTC) #2

Vasily Kuznetsov

Hi Tudor, Looking pretty good there. I have one question and one nit. Cheers, Vasily ...

Oct. 16, 2018, 2:52 p.m. (2018-10-16 14:52:54 UTC) #3

Tudor Avram

Hi Vasily, I addressed your comments from Patch Set #1. I also added a short ...

Oct. 18, 2018, 4:29 p.m. (2018-10-18 16:29:24 UTC) #4

Vasily Kuznetsov

Oct. 19, 2018, 12:47 p.m. (2018-10-19 12:47:29 UTC) #5

LGTM

https://codereview.adblockplus.org/29908581/diff/29915569/tests/utils.py
File tests/utils.py (right):

https://codereview.adblockplus.org/29908581/diff/29915569/tests/utils.py#newc...
tests/utils.py:106: """Mock arguments for the XTM integration script."""
Yay, docstrings!

Expand All Messages | Collapse All Messages