Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(125)

Issue 29926557: Issue 6994 - Use shortcut matching for location-only filters (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months, 3 weeks ago by Manish Jethani
Modified:
11 months, 3 weeks ago
Reviewers:
Jon Sonesen, hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Minor update #

Patch Set 3 : Fix comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -28 lines) Patch
M lib/filterClasses.js View 1 chunk +13 lines, -0 lines 0 comments Download
M lib/matcher.js View 1 2 3 chunks +59 lines, -23 lines 1 comment Download
M test/filterListener.js View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
11 months, 3 weeks ago (2018-10-25 20:43:35 UTC) #1
Manish Jethani
Patch Set 1 & 2 I'm seeing ~10% improvement in performance with EasyList+AA using the ...
11 months, 3 weeks ago (2018-10-25 21:24:11 UTC) #2
Manish Jethani
Patch Set 3 https://codereview.adblockplus.org/29926557/diff/29926566/lib/matcher.js File lib/matcher.js (right): https://codereview.adblockplus.org/29926557/diff/29926566/lib/matcher.js#newcode202 lib/matcher.js:202: // not contain any default content ...
11 months, 3 weeks ago (2018-10-25 21:28:40 UTC) #3
Jon Sonesen
Hey Manish, LGTM, up to you if you wish to wait for Hub. Thanks!
11 months, 3 weeks ago (2018-10-29 22:15:33 UTC) #4
hub
11 months, 3 weeks ago (2018-10-30 04:07:57 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5