Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(234)

Issue 29931564: Issue 7080 - Don't tranlsate product name in builds for Microsoft Edge (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months, 3 weeks ago by Sebastian Noack
Modified:
11 months, 2 weeks ago
Reviewers:
tlucas
Visibility:
Public.

Description

Issue 7080 - Don't tranlsate product name in builds for Microsoft Edge

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -33 lines) Patch
M package.json View 1 1 chunk +1 line, -1 line 0 comments Download
M packagerEdge.py View 1 3 chunks +18 lines, -13 lines 0 comments Download
M tests/expecteddata/AppxManifest_edge_development_build.xml View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/expecteddata/AppxManifest_edge_release_build.xml View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/expecteddata/manifest_edge_development_build.json View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/expecteddata/manifest_edge_devenv.json View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/expecteddata/manifest_edge_release_build.json View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/test_packagerWebExt.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Sebastian Noack
11 months, 3 weeks ago (2018-10-30 23:28:43 UTC) #1
tlucas
On 2018/10/30 23:28:43, Sebastian Noack wrote: Would you mind rebasing this against the current master?
11 months, 3 weeks ago (2018-10-31 09:01:34 UTC) #2
Sebastian Noack
On 2018/10/31 09:01:34, tlucas wrote: > Would you mind rebasing this against the current master? ...
11 months, 2 weeks ago (2018-10-31 18:32:04 UTC) #3
tlucas
11 months, 2 weeks ago (2018-10-31 18:52:27 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5