Issue 7003 - Add tests for new filter matching behavior

test/matcher.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 40 matching lines @@
         let dummyFilter = Filter.fromText("^" + keyword + "^");
         dummyFilter.filterCount = Infinity;
         matcher.add(dummyFilter);
       }
     }
 
     test.equal(result.join(", "), expected.join(", "), "Keyword candidates for " + filter.text);
   }
 }
 
-function checkMatch(test, filters, location, contentType, docDomain, thirdParty, sitekey, specificOnly, expected)
+function checkMatch(test, filters, location, contentType, docDomain, thirdParty, sitekey, specificOnly, expected, expectedFirstMatch = expected)

[Manish Jethani, 2018/11/01 01:00:34]

A standalone matcher will always return the first match regardless of filter
type, but a combined matcher will return a whitelist filter only if there's also
a matching blacklist filter. We need to check both here.

 {
   let matcher = new Matcher();
   for (let filter of filters)
     matcher.add(Filter.fromText(filter));
 
   let result = matcher.matchesAny(location, RegExpFilter.typeMap[contentType], docDomain, thirdParty, sitekey, specificOnly);
   if (result)
     result = result.text;
 
-  test.equal(result, expected, "match(" + location + ", " + contentType + ", " + docDomain + ", " + (thirdParty ? "third-party" : "first-party") + ", " + (sitekey || "no-sitekey") + ", " + (specificOnly ? "specificOnly" : "not-specificOnly") + ") with:\n" + filters.join("\n"));
+  test.equal(result, expectedFirstMatch, "match(" + location + ", " + contentType + ", " + docDomain + ", " + (thirdParty ? "third-party" : "first-party") + ", " + (sitekey || "no-sitekey") + ", " + (specificOnly ? "specificOnly" : "not-specificOnly") + ") with:\n" + filters.join("\n"));
 
   let combinedMatcher = new CombinedMatcher();
   for (let i = 0; i < 2; i++)
   {
     for (let filter of filters)
       combinedMatcher.add(Filter.fromText(filter));
 
     result = combinedMatcher.matchesAny(location, RegExpFilter.typeMap[contentType], docDomain, thirdParty, sitekey, specificOnly);
     if (result)
       result = result.text;
@@ skipping 120 matching lines @@
   checkMatch(test, ["abc$sitekey=foo-publickey,domain=foo.com", "abc$sitekey=bar-publickey,domain=bar.com"], "http://abc/def", "IMAGE", "foo.com", false, "foo-publickey", false, "abc$sitekey=foo-publickey,domain=foo.com");
   checkMatch(test, ["abc$sitekey=foo-publickey,domain=foo.com", "abc$sitekey=bar-publickey,domain=bar.com"], "http://abc/def", "IMAGE", "foo.com", false, "bar-publickey", false, null);
   checkMatch(test, ["abc$sitekey=foo-publickey,domain=foo.com", "abc$sitekey=bar-publickey,domain=bar.com"], "http://abc/def", "IMAGE", "bar.com", false, "foo-publickey", false, null);
   checkMatch(test, ["abc$sitekey=foo-publickey,domain=foo.com", "abc$sitekey=bar-publickey,domain=bar.com"], "http://abc/def", "IMAGE", "bar.com", false, "bar-publickey", false, "abc$sitekey=bar-publickey,domain=bar.com");
   checkMatch(test, ["@@foo.com$generichide"], "http://foo.com/bar", "GENERICHIDE", "foo.com", false, null, false, "@@foo.com$generichide");
   checkMatch(test, ["@@foo.com$genericblock"], "http://foo.com/bar", "GENERICBLOCK", "foo.com", false, null, false, "@@foo.com$genericblock");
   checkMatch(test, ["@@bar.com$generichide"], "http://foo.com/bar", "GENERICHIDE", "foo.com", false, null, false, null);
   checkMatch(test, ["@@bar.com$genericblock"], "http://foo.com/bar", "GENERICBLOCK", "foo.com", false, null, false, null);
   checkMatch(test, ["/bar"], "http://foo.com/bar", "IMAGE", "foo.com", false, null, true, null);
   checkMatch(test, ["/bar$domain=foo.com"], "http://foo.com/bar", "IMAGE", "foo.com", false, null, true, "/bar$domain=foo.com");
+  checkMatch(test, ["@@||foo.com^"], "http://foo.com/bar", "IMAGE", "foo.com", false, null, false, null, "@@||foo.com^");

[Manish Jethani, 2018/11/01 01:00:34]

Here "expectedFirstMatch" is the whitelist filter but "expected' is null.

+  checkMatch(test, ["/bar", "@@||foo.com^"], "http://foo.com/bar", "IMAGE", "foo.com", false, null, false, "@@||foo.com^");
+  checkMatch(test, ["/bar", "@@||foo.com^"], "http://foo.com/foo", "IMAGE", "foo.com", false, null, false, null, "@@||foo.com^");
 
   test.done();
 };
 
 exports.testResultCacheChecks = function(test)
 {
   let matcher = new CombinedMatcher();
   matcher.add(Filter.fromText("abc$image"));
   matcher.add(Filter.fromText("abc$script"));
   matcher.add(Filter.fromText("abc$~image,~script,~media,~ping"));
@@ skipping 17 matching lines @@
   cacheCheck(test, matcher, "http://fed", "IMAGE", null, true, "http://fed$third-party");
   cacheCheck(test, matcher, "http://abc_cba", "MEDIA", null, false, "cba$~third-party,~script");
   cacheCheck(test, matcher, "http://abc_cba", "MEDIA", null, true, "cba$third-party");
   cacheCheck(test, matcher, "http://abc_cba", "SCRIPT", null, false, "abc$script");
   cacheCheck(test, matcher, "http://def?http://fed", "MEDIA", null, false, "http://fed$~third-party,~script");
   cacheCheck(test, matcher, "http://def?http://fed", "MEDIA", null, true, "http://fed$third-party");
   cacheCheck(test, matcher, "http://def?http://fed", "SCRIPT", null, false, "http://def$script");
 
   test.done();
 };