tests/expected_output/relative/en/foo/bar - Issue 29933596: Issue 5333 - Allow cms to generate relative pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: tests/expected_output/relative/en/foo/bar

Issue 29933596: Issue 5333 - Allow cms to generate relative pages (Closed) Base URL: https://hg.adblockplus.org/cms/

Patch Set: Translate rel_path Created Nov. 8, 2018, 2:48 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <body>

	2 File used for to test the correct generation of pages within that

	3 are located in some place other than root.

	4

	5 It is also used to test the correct handling of a case where a

	6 file is replaced by a directory of vice-versa.

	7

	8 Relative link to page in superfolder: <a href="../sitemap">

	9 Absolute link to page in superfolder: <a href="../../en/sitemap">
	Vasily Kuznetsov 2018/11/08 14:36:14 It seems that this link actually becomes "../sitem It seems that this link actually becomes "../sitemap" just like the other one -- it makes sense given that this page is itself inside of "/en". rhowell 2018/11/08 20:05:18 Weird, I wonder why that test was passing on my en Show quoted text On 2018/11/08 14:36:14, Vasily Kuznetsov wrote: > It seems that this link actually becomes "../sitemap" just like the other one -- > it makes sense given that this page is itself inside of "/en". Weird, I wonder why that test was passing on my end. When I tried to fix this, it failed. But, if I add /de/foo/bar with this ^ result, everything seems to be passing again. Sanity check: linking from /de/foo/bar to /en/sitemap should result in ../../en/sitemap, right? Vasily Kuznetsov 2018/11/09 10:53:27 Great, adding /de/foo/bar to the outputs seems lik Show quoted text On 2018/11/08 20:05:18, rhowell wrote: > On 2018/11/08 14:36:14, Vasily Kuznetsov wrote: > > It seems that this link actually becomes "../sitemap" just like the other one > -- > > it makes sense given that this page is itself inside of "/en". > > Weird, I wonder why that test was passing on my end. When I tried to fix this, > it failed. But, if I add /de/foo/bar with this ^ result, everything seems to be > passing again. Great, adding /de/foo/bar to the outputs seems like a useful test for this page. Show quoted text > Sanity check: linking from /de/foo/bar to /en/sitemap should result in > ../../en/sitemap, right? Yes, that's correct.
	10 </body>

OLD	NEW

« cms/converters.py ('K') | « tests/expected_output/relative/de/rel_path ('k') | tests/expected_output/relative/en/rel_path » ('j') | no next file with comments »