Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Unified Diff: tests/expected_output/en/dynamic/get_page_url
Issue
29933596
:
Issue 5333 - Allow cms to generate relative pages (Closed)
Base URL: https://hg.adblockplus.org/cms/
Patch Set: Address comments on PS1, rearrange test files
Created Nov. 6, 2018, 3:28 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
cms/bin/generate_static_pages.py
cms/converters.py
cms/utils.py
tests/expected_output/de/common/translate-partial
tests/expected_output/de/dynamic/translate
tests/expected_output/de/dynamic/translate-html
tests/expected_output/de/dynamic/translate-include
tests/expected_output/de/dynamic/translate-not-enough
tests/expected_output/de/dynamic/translate-template
tests/expected_output/de/dynamic/translate-tmpl
tests/expected_output/de/relative/translate
tests/expected_output/de/relative/translate-html
tests/expected_output/de/relative/translate-include
tests/expected_output/de/relative/translate-template
tests/expected_output/de/relative/translate-tmpl
tests/expected_output/de/static/translate
tests/expected_output/de/static/translate-html
tests/expected_output/de/static/translate-include
tests/expected_output/de/static/translate-not-enough
tests/expected_output/de/static/translate-template
tests/expected_output/de/static/translate-tmpl
tests/expected_output/en/common/filter
tests/expected_output/en/common/global
tests/expected_output/en/common/includer
tests/expected_output/en/common/metadata_json
tests/expected_output/en/common/metadata_json_comment
tests/expected_output/en/common/metadata_old_comment
tests/expected_output/en/common/sitemap
tests/expected_output/en/dynamic/get_page_url
tests/expected_output/en/dynamic/rel_path
tests/expected_output/en/dynamic/siteurl
tests/expected_output/en/dynamic/translate
tests/expected_output/en/dynamic/translate-html
tests/expected_output/en/dynamic/translate-include
tests/expected_output/en/dynamic/translate-template
tests/expected_output/en/dynamic/translate-tmpl
tests/expected_output/en/get_page_url@static
tests/expected_output/en/relative/get_page_url
tests/expected_output/en/relative/rel_path
tests/expected_output/en/relative/siteurl
tests/expected_output/en/relative/translate
tests/expected_output/en/relative/translate-html
tests/expected_output/en/relative/translate-include
tests/expected_output/en/relative/translate-template
tests/expected_output/en/relative/translate-tmpl
tests/expected_output/en/siteurl@static
tests/expected_output/en/static/get_page_url
tests/expected_output/en/static/rel_path
tests/expected_output/en/static/siteurl
tests/expected_output/en/static/translate
tests/expected_output/en/static/translate-html
tests/expected_output/en/static/translate-include
tests/expected_output/en/static/translate-template
tests/expected_output/en/static/translate-tmpl
tests/test_dynamic_server.py
tests/test_page_outputs.py
tests/utils.py
View side-by-side diff with in-line comments
Download patch
« cms/converters.py
('K') |
« tests/expected_output/en/common/sitemap
('k') |
tests/expected_output/en/dynamic/rel_path »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: tests/expected_output/en/dynamic/get_page_url
===================================================================
rename from tests/expected_output/en/get_page_url@dynamic
rename to tests/expected_output/en/dynamic/get_page_url
« cms/converters.py
('K') |
« tests/expected_output/en/common/sitemap
('k') |
tests/expected_output/en/dynamic/rel_path »
('j') |
no next file with comments »
Edit Message
Issue 29933596: Issue 5333 - Allow cms to generate relative pages (Closed)
Created Nov. 2, 2018, 2:48 a.m. by rhowell
Modified Jan. 9, 2019, 10:56 p.m.
Reviewers: Vasily Kuznetsov
Base URL: https://hg.adblockplus.org/cms/
Comments: 31
This is Rietveld