Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29934561: #1537 - Remove stats processing from sitescripts (Closed)

Created:
Nov. 2, 2018, 12:42 p.m. by Vasily Kuznetsov
Modified:
Nov. 8, 2018, 9:21 a.m.
Reviewers:
mathias
Base URL:
https://hg.adblockplus.org/sitescripts
Visibility:
Public.

Description

#1537 - Remove stats processing from sitescripts Repository: hg.adblockplus.org/sitescripts Base revision: c4de0577fd41

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -5742 lines) Patch
M .sitescripts.example View 1 chunk +0 lines, -17 lines 0 comments Download
R pygeoip/LICENSE.md View 1 chunk +0 lines, -165 lines 0 comments Download
R pygeoip/README.md View 1 chunk +0 lines, -95 lines 0 comments Download
R pygeoip/__init__.py View 1 chunk +0 lines, -668 lines 0 comments Download
R pygeoip/const.py View 1 chunk +0 lines, -431 lines 0 comments Download
R pygeoip/timezone.py View 1 chunk +0 lines, -760 lines 0 comments Download
R pygeoip/util.py View 1 chunk +0 lines, -36 lines 0 comments Download
R sitescripts/stats/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
R sitescripts/stats/bin/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
R sitescripts/stats/bin/logprocessor.py View 1 chunk +0 lines, -603 lines 0 comments Download
R sitescripts/stats/bin/pagegenerator.py View 1 chunk +0 lines, -189 lines 0 comments Download
R sitescripts/stats/common.py View 1 chunk +0 lines, -171 lines 0 comments Download
R sitescripts/stats/countrycodes.py View 1 chunk +0 lines, -3 lines 0 comments Download
R sitescripts/stats/static/flags.css View 1 chunk +0 lines, -1265 lines 0 comments Download
R sitescripts/stats/static/flags.png View Binary file 0 comments Download
R sitescripts/stats/static/hours.css View 1 chunk +0 lines, -73 lines 0 comments Download
R sitescripts/stats/static/hours.png View Binary file 0 comments Download
R sitescripts/stats/static/stats.css View 1 chunk +0 lines, -118 lines 0 comments Download
R sitescripts/stats/template/fileOverview.html View 1 chunk +0 lines, -76 lines 0 comments Download
R sitescripts/stats/template/fileStats.html View 1 chunk +0 lines, -202 lines 0 comments Download
R sitescripts/stats/template/main.html View 1 chunk +0 lines, -71 lines 0 comments Download
R sitescripts/stats/test/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
R sitescripts/stats/test/common.py View 1 chunk +0 lines, -49 lines 0 comments Download
R sitescripts/stats/test/logprocessor.py View 1 chunk +0 lines, -745 lines 0 comments Download
M tox.ini View 2 chunks +1 line, -8 lines 2 comments Download

Messages

Total messages: 3
Vasily Kuznetsov
Hey Matze! Here's the change to remove `stats` (and `pygeoip` that it uses) from sitescripts. ...
Nov. 2, 2018, 12:44 p.m. (2018-11-02 12:44:59 UTC) #1
mathias
LGTM with one remark at your discretion. https://codereview.adblockplus.org/29934561/diff/29934562/tox.ini File tox.ini (right): https://codereview.adblockplus.org/29934561/diff/29934562/tox.ini#newcode112 tox.ini:112: sitescripts/reports/tests \ ...
Nov. 8, 2018, 8:20 a.m. (2018-11-08 08:20:03 UTC) #2
Vasily Kuznetsov
Nov. 8, 2018, 8:55 a.m. (2018-11-08 08:55:31 UTC) #3 
Hi Matze!

Thanks for the review. I think that little unrelated change is ok to land
together with this patch (see more detailed comment below).

Now let's coordinate and do it carefully so we don't explode stuff.

Cheers,
Vasily

https://codereview.adblockplus.org/29934561/diff/29934562/tox.ini
File tox.ini (right):

https://codereview.adblockplus.org/29934561/diff/29934562/tox.ini#newcode112
tox.ini:112: sitescripts/reports/tests \
On 2018/11/08 08:20:02, mathias wrote:
> This change is unrelated, isn't it?

Yes, indeed, this is unrelated. But it was close enough to the stuff I was
changing and it looked messy, so you know, boy scout rule.

Powered by Google App Engine
This is Rietveld