Issue 7094 - Encapsulate management of subscription filters

lib/filterListener.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 14 matching lines @@
 const {Services} = Cu.import("resource://gre/modules/Services.jsm", {});
 const {XPCOMUtils} = Cu.import("resource://gre/modules/XPCOMUtils.jsm", {});
 
 const {filterStorage} = require("./filterStorage");
 const {filterNotifier} = require("./filterNotifier");
 const {ElemHide} = require("./elemHide");
 const {ElemHideEmulation} = require("./elemHideEmulation");
 const {ElemHideExceptions} = require("./elemHideExceptions");
 const {Snippets} = require("./snippets");
 const {defaultMatcher} = require("./matcher");
-const {Filter, ActiveFilter, RegExpFilter,
+const {ActiveFilter, RegExpFilter,
        ElemHideBase, ElemHideFilter, ElemHideEmulationFilter,
        SnippetFilter} = require("./filterClasses");
 const {SpecialSubscription} = require("./subscriptionClasses");
 const {Prefs} = require("prefs");
 
 /**
  * Increases on filter changes, filters will be saved if it exceeds 1.
  * @type {number}
  */
 let isDirty = 0;
@@ skipping 166 matching lines @@
       ElemHideEmulation.remove(filter);
     else
       ElemHideExceptions.remove(filter);
   }
   else if (filter instanceof SnippetFilter)
     Snippets.remove(filter);
 }
 
 const primes = [101, 109, 131, 149, 163, 179, 193, 211, 229, 241];
 
-function addFilters(filters, filterObjects)
+function addSubscriptionFilters(subscription)
 {
   // We add filters using pseudo-random ordering. Reason is that ElemHide will
   // assign consecutive filter IDs that might be visible to the website. The
   // randomization makes sure that no conclusion can be made about the actual
   // filters applying there. We have ten prime numbers to use as iteration step,
   // any of those can be chosen as long as the array length isn't divisible by
   // it.
-  let len = filterObjects ? filterObjects.length : filters.length;
+  let len = subscription.filterCount;
   if (!len)
     return;
 
   let current = (Math.random() * len) | 0;
   let step;
   do
   {
     step = primes[(Math.random() * primes.length) | 0];
   } while (len % step == 0);
 
   for (let i = 0; i < len; i++, current = (current + step) % len)
-  {
-    addFilter(filterObjects ? filterObjects[current] :
-                Filter.fromText(filters[current]));
-  }
+    addFilter(subscription.filterAt(current));
 }
 
 function onSubscriptionAdded(subscription)
 {
   FilterListener.setDirty(1);
 
   if (!subscription.disabled)
-    addFilters(subscription.filters);
+    addSubscriptionFilters(subscription);
 }
 
 function onSubscriptionRemoved(subscription)
 {
   FilterListener.setDirty(1);
 
   if (!subscription.disabled)
   {
-    for (let text of subscription.filters)
-      removeFilter(Filter.fromText(text));
+    for (let filter of subscription.filters())
+      removeFilter(filter);
   }
 }
 
 function onSubscriptionDisabled(subscription, newValue)
 {
   FilterListener.setDirty(1);
 
   if (filterStorage.knownSubscriptions.has(subscription.url))
   {
     if (newValue == false)
     {
-      addFilters(subscription.filters);
+      addSubscriptionFilters(subscription);
     }
     else
     {
-      for (let text of subscription.filters)
-        removeFilter(Filter.fromText(text));
+      for (let filter of subscription.filters())
+        removeFilter(filter);
     }
   }
 }
 
 function onSubscriptionUpdated(subscription, oldFilters)
 {
   FilterListener.setDirty(1);
 
   if (!subscription.disabled &&
       filterStorage.knownSubscriptions.has(subscription.url))
   {
-    for (let text of oldFilters)
-      removeFilter(Filter.fromText(text));
-
-    addFilters(subscription.filters);
+    for (let filter of oldFilters)
+      removeFilter(filter);
+
+    addSubscriptionFilters(subscription);
   }
 }
 
 function onFilterHitCount(filter, newValue)
 {
   if (newValue == 0)
     FilterListener.setDirty(0);
   else
     FilterListener.setDirty(0.002);
 }
@@ skipping 36 matching lines @@
 
 function onLoad()
 {
   isDirty = 0;
 
   defaultMatcher.clear();
   ElemHide.clear();
   ElemHideEmulation.clear();
   ElemHideExceptions.clear();
   Snippets.clear();
+
   for (let subscription of filterStorage.subscriptions())
   {
     if (!subscription.disabled)
-      addFilters(subscription.filters, subscription.filterObjects);
-
-    subscription.filterObjects = null;
+      addSubscriptionFilters(subscription);
   }
 }
 
 function onSave()
 {
   isDirty = 0;
 }