Issue 7094 - Encapsulate management of subscription filters

test/synchronizer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 123 matching lines @@
       return [Cr.NS_OK, 200, currentTest.header + "\n!Expires: 8 hours\nfoo\n!bar\n\n@@bas\n#bam"];
     });
 
     this.runScheduledTasks(2).then(() =>
     {
       test.equal(subscription.downloadStatus, currentTest.downloadStatus, "Download status");
       test.equal(subscription.requiredVersion, currentTest.requiredVersion, "Required version");
 
       if (currentTest.downloadStatus == "synchronize_ok")
       {
-        test.deepEqual(subscription.filters, ["foo", "!bar", "@@bas", "#bam"], "Resulting subscription filters");
+        test.deepEqual([...subscription.filterText()], ["foo", "!bar", "@@bas", "#bam"], "Resulting subscription filters");
       }
       else
       {
-        test.deepEqual(subscription.filters, [
+        test.deepEqual([...subscription.filterText()], [
         ], "Resulting subscription filters");
       }
     }).catch(unexpectedError.bind(test)).then(() => test.done());
   };
 }
 
 exports.testsDisabledUpdates = function(test)
 {
   Prefs.subscriptions_autoupdate = false;
 
@@ skipping 134 matching lines @@
     filterStorage.addSubscription(subscription);
 
     this.registerHandler("/subscription", metadata =>
     {
       return [Cr.NS_OK, 200, "[Adblock]\n" + comment + "\nfoo\nbar"];
     });
 
     this.runScheduledTasks(2).then(() =>
     {
       check(test, subscription);
-      test.deepEqual(subscription.filters, ["foo", "bar"], "Special comment not added to filters");
+      test.deepEqual([...subscription.filterText()], ["foo", "bar"], "Special comment not added to filters");
     }).catch(unexpectedError.bind(test)).then(() => test.done());
   };
 }
 
 exports.testRedirects = function(test)
 {
   let subscription = Subscription.fromURL("http://example.com/subscription");
   filterStorage.addSubscription(subscription);
 
   this.registerHandler("/subscription", metadata =>
@@ skipping 182 matching lines @@
     return this.runScheduledTasks(24);
   }).then(() =>
   {
     test.equal(subscription.downloadStatus, "synchronize_connection_error", "downloadStatus after download error");
     test.equal(subscription.lastDownload * MILLIS_IN_SECOND, startTime + (26 + initialDelay) * MILLIS_IN_HOUR, "lastDownload after download error");
     test.equal(subscription.lastSuccess * MILLIS_IN_SECOND, startTime + initialDelay * MILLIS_IN_HOUR, "lastSuccess after download error");
     test.equal(subscription.lastCheck * MILLIS_IN_SECOND, startTime + (27 + initialDelay) * MILLIS_IN_HOUR, "lastCheck after download error");
     test.equal(subscription.errors, 2, "errors after download error");
   }).catch(unexpectedError.bind(test)).then(() => test.done());
 };
+
+exports.testSpecialCommentOrdering = function(test)
+{
+  let subscription = Subscription.fromURL("http://example.com/subscription");
+  filterStorage.addSubscription(subscription);
+
+  this.registerHandler("/subscription", metadata =>
+  {
+    return [Cr.NS_OK, 200, "[Adblock]\n! Special Comment: x\n!foo\n! Title: foobar\nfoo\nbar"];
+  });
+
+  this.runScheduledTasks(1).then(() =>
+  {
+    test.equal(subscription.title, "http://example.com/subscription", "make sure title was not found");
+  }).catch(unexpectedError.bind(test)).then(() => test.done());
+};
+
+exports.testUnknownSpecialComments = function(test)
+{
+  let subscription = Subscription.fromURL("http://example.com/subscription");
+  filterStorage.addSubscription(subscription);
+
+  this.registerHandler("/subscription", metadata =>
+  {
+    // To test allowing unknown special comments like `! :`, `!!@#$%^&*() : `, and `! Some Unknown Comment : `
+    return [Cr.NS_OK, 200, "[Adblock]\n! :\n! !@#$%^&*() :\n! Some Unknown Comment :\n! Title: foobar\nfoo\nbar"];
+  });
+
+  this.runScheduledTasks(1).then(() =>
+  {
+    test.equal(subscription.title, "foobar", "make sure title was found");
+  }).catch(unexpectedError.bind(test)).then(() => test.done());
+};