Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/iniParser.js

Issue 29934588: Issue 7094 - Encapsulate management of subscription filters (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Nov. 2, 2018, 10:34 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/filterStorage.js ('k') | lib/subscriptionClasses.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/iniParser.js
===================================================================
--- a/lib/iniParser.js
+++ b/lib/iniParser.js
@@ -92,29 +92,33 @@
case "filter":
if ("text" in this._curObj)
Filter.fromObject(this._curObj);
break;
case "subscription":
let subscription = Subscription.fromObject(this._curObj);
if (subscription)
+ {
this.subscriptions.push(subscription);
+ subscription.filterObjects = [];
+ }
break;
case "subscription filters":
if (this.subscriptions.length)
{
let currentSubscription = this.subscriptions[
this.subscriptions.length - 1
];
for (let text of this._curObj)
{
let filter = Filter.fromText(text);
- currentSubscription.filters.push(filter);
+ currentSubscription.filters.push(filter.text);
+ currentSubscription.filterObjects.push(filter);
filter.addSubscription(currentSubscription);
}
}
break;
}
}
if (line === null)
« no previous file with comments | « lib/filterStorage.js ('k') | lib/subscriptionClasses.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld