Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/filterClasses.js

Issue 29935568: Issue 7096 - Make it possible to lazy initialize a filter's subscriptions (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Nov. 3, 2018, 9:19 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/filterListener.js » ('j') | lib/filterListener.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/filterClasses.js
===================================================================
--- a/lib/filterClasses.js
+++ b/lib/filterClasses.js
@@ -55,23 +55,16 @@
* Abstract base class for filters
*
* @param {string} text string representation of the filter
* @constructor
*/
function Filter(text)
{
this.text = text;
-
- /**
- * Subscriptions to which this filter belongs.
- * @type {(Subscription|Set.<Subscription>)?}
- * @private
- */
- this._subscriptions = null;
}
exports.Filter = Filter;
Filter.prototype =
{
/**
* String representation of the filter
* @type {string}
@@ -83,16 +76,37 @@
* @type {string}
*/
get type()
{
throw new Error("Please define filter type in the subclass");
},
/**
+ * Subscriptions to which this filter belongs.
+ * @type {(Subscription|Set.<Subscription>)?}
+ * @private
+ */
+ _subscriptions: null,
+
+ /**
+ * Whether the filter's subscriptions have already been added to the filter.
+ * @type {boolean}
+ * @package
+ */
+ get subscriptionsAdded()
+ {
+ return this.hasOwnProperty("_subscriptions");
+ },
+ set subscriptionsAdded(value)
+ {
+ this._subscriptions = this._subscriptions;
+ },
+
+ /**
* Yields subscriptions to which the filter belongs.
* @yields {Subscription}
*/
*subscriptions()
{
if (this._subscriptions)
{
if (this._subscriptions instanceof Set)
« no previous file with comments | « no previous file | lib/filterListener.js » ('j') | lib/filterListener.js » ('J')

Powered by Google App Engine
This is Rietveld