Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74)

Issue 29938555: Noissue - Upgrade to selenium-webdriver 4.0.0-alpha (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 2 weeks ago by hub
Modified:
9 months, 2 weeks ago
Reviewers:
hub, Sebastian Noack
CC:
geo, tlucas, Jon Sonesen
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Noissue - Upgrade to selenium-webdriver 4.0.0-alpha COLLABORATOR=sebastian@adblockplus.org

Patch Set 1 #

Total comments: 10

Patch Set 2 : Fix typo in package version #

Total comments: 4

Patch Set 3 : renamed "loc" to "rect" and change selenium package version request. #

Patch Set 4 : Updated README #

Patch Set 5 : Some changes I was missing #

Patch Set 6 : Fixed timing issue on Chrome by taking screenshots in order #

Total comments: 2

Patch Set 7 : Renamed loc to rect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -30 lines) Patch
M README.md View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M package.json View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/browsers/firefox.js View 1 2 3 4 5 1 chunk +3 lines, -12 lines 0 comments Download
M test/wrappers/pages.js View 1 2 3 4 5 6 2 chunks +17 lines, -16 lines 0 comments Download

Messages

Total messages: 14
hub
9 months, 2 weeks ago (2018-11-06 08:32:47 UTC) #1
hub
We hope this should work better for MSEdge, even though this is alpha1. I have ...
9 months, 2 weeks ago (2018-11-06 08:39:48 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29938555/diff/29938556/package.json File package.json (right): https://codereview.adblockplus.org/29938555/diff/29938556/package.json#newcode25 package.json:25: "selenium-webdriver": "4.0.0-alpha1", We might want to require ^4.0.0-alpha here. ...
9 months, 2 weeks ago (2018-11-06 09:02:33 UTC) #3
tlucas
https://codereview.adblockplus.org/29938555/diff/29938556/package.json File package.json (right): https://codereview.adblockplus.org/29938555/diff/29938556/package.json#newcode25 package.json:25: "selenium-webdriver": "4.0.0-alpha1", On 2018/11/06 09:02:33, Sebastian Noack wrote: > ...
9 months, 2 weeks ago (2018-11-07 08:57:16 UTC) #4
hub
updated patch https://codereview.adblockplus.org/29938555/diff/29938556/package.json File package.json (right): https://codereview.adblockplus.org/29938555/diff/29938556/package.json#newcode25 package.json:25: "selenium-webdriver": "4.0.0-alpha1", On 2018/11/06 09:02:33, Sebastian Noack ...
9 months, 2 weeks ago (2018-11-07 17:13:37 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29938555/diff/29939616/package.json File package.json (right): https://codereview.adblockplus.org/29938555/diff/29939616/package.json#newcode25 package.json:25: "selenium-webdriver": "4.0.0-alpha.1", ^4.0.0-alpha (as I initially suggested) woul work ...
9 months, 2 weeks ago (2018-11-07 18:35:49 UTC) #6
hub
Updated patch. There is still a failure on Chrome (time out), I need to resolve. ...
9 months, 2 weeks ago (2018-11-08 19:02:22 UTC) #7
Sebastian Noack
LGTM
9 months, 2 weeks ago (2018-11-08 21:39:43 UTC) #8
Sebastian Noack
Another more thing, I just noticed, Selenium 4.0.0 requires Node.js 8.9 or higher, we should ...
9 months, 2 weeks ago (2018-11-08 22:02:06 UTC) #9
hub
updated patch
9 months, 2 weeks ago (2018-11-09 20:16:32 UTC) #10
Sebastian Noack
I added a new patch set, fixing the test failure on Chromium. (The changes in ...
9 months, 2 weeks ago (2018-11-09 22:18:52 UTC) #11
hub
https://codereview.adblockplus.org/29938555/diff/29941678/test/wrappers/pages.js File test/wrappers/pages.js (right): https://codereview.adblockplus.org/29938555/diff/29941678/test/wrappers/pages.js#newcode70 test/wrappers/pages.js:70: lastScreenshot]).then(([loc]) => you might have taken the wrong version ...
9 months, 2 weeks ago (2018-11-09 22:23:31 UTC) #12
Sebastian Noack
https://codereview.adblockplus.org/29938555/diff/29941678/test/wrappers/pages.js File test/wrappers/pages.js (right): https://codereview.adblockplus.org/29938555/diff/29941678/test/wrappers/pages.js#newcode70 test/wrappers/pages.js:70: lastScreenshot]).then(([loc]) => On 2018/11/09 22:23:31, hub wrote: > you ...
9 months, 2 weeks ago (2018-11-09 22:26:53 UTC) #13
hub
9 months, 2 weeks ago (2018-11-09 22:31:55 UTC) #14
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5