Noissue - Upgrade to selenium-webdriver 4.0.0-alpha

test/browsers/firefox.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 15 matching lines @@
 // We need to require the geckodriver,
 // otherwise on Windows the geckodriver path is not added to process.env.PATH.
 require("geckodriver");
 
 exports.platform = "gecko";
 exports.oldestCompatibleVersion = "57.0";
 exports.ensureBrowser = ensureFirefox;
 
 exports.getDriver = function(browserBinary, devenvPath)
 {
-  let options = new firefox.Options();
-  options.setBinary(browserBinary);
-  options.headless();
-
+  let options = new firefox.Options().setBinary(browserBinary).headless();
   let driver = new webdriver.Builder()
     .forBrowser("firefox")
     .setFirefoxOptions(options)
     .build();
 
-  let cmd = new Command("moz-install-web-ext")
-    .setParameter("path", devenvPath)
-    .setParameter("temporary", true);
+  let cmd = new Command("install addon")
+      .setParameter("path", devenvPath)

[Sebastian Noack, 2018/11/06 09:02:33]

Nit: The indentation seems to be off here by 2 spaces.

[hub, 2018/11/07 17:13:37]

Done.

+      .setParameter("temporary", true);
 
-  driver.getExecutor().defineCommand(
-    cmd.getName(), "POST",
-    "/session/:sessionId/moz/addon/install"
-  );
-  driver.schedule(cmd, `installWebExt(${devenvPath})`);
+  driver.execute(cmd);

[Sebastian Noack, 2018/11/06 09:02:33]

Nit: I think we don't need the cmd variable anymore (previously it was
referenced twice, now it could be inlined).

[hub, 2018/11/07 17:13:37]

Done.

 
   return driver;
 };