package.json - Issue 29938555: Noissue - Upgrade to selenium-webdriver 4.0.0-alpha

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: package.json

Issue 29938555: Noissue - Upgrade to selenium-webdriver 4.0.0-alpha (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Left Patch Set: Created Nov. 6, 2018, 8:32 a.m.

Right Patch Set: Renamed loc to rect Created Nov. 9, 2018, 10:26 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {	1 {

2 "name": "adblockpluschrome",	2 "name": "adblockpluschrome",

3 "repository": "https://hg.adblockplus.org/adblockpluschrome",	3 "repository": "https://hg.adblockplus.org/adblockpluschrome",

4 "license": "GPL-3.0",	4 "license": "GPL-3.0",

5 "dependencies": {},	5 "dependencies": {},

6 "devDependencies": {	6 "devDependencies": {

7 "//": [	7 "//": [

8 "'dmg', 'extract-zip' and 'ncp' are needed by `download_*.js` modules",	8 "'dmg', 'extract-zip' and 'ncp' are needed by `download_*.js` modules",

9 "in adblockpluscore/test/.",	9 "in adblockpluscore/test/.",

10 "The chromedriver version was pinned to that exact version, due to",	10 "The chromedriver version was pinned to that exact version, due to",

11 "incompatibilities with the configured chromium version and newer",	11 "incompatibilities with the configured chromium version and newer",

12 "drivers."	12 "drivers."

13 ],	13 ],

14 "argparse": "^1.0.10",	14 "argparse": "^1.0.10",

15 "chromedriver": "2.36.0",	15 "chromedriver": "2.36.0",

16 "dmg": "^0.1.0",	16 "dmg": "^0.1.0",

17 "eslint": "^5.1.0",	17 "eslint": "^5.1.0",

18 "eslint-config-eyeo": "^2.1.0",	18 "eslint-config-eyeo": "^2.1.0",

19 "extract-zip": "^1.6.5",	19 "extract-zip": "^1.6.5",

20 "geckodriver": "^1.9.0",	20 "geckodriver": "1.12.2",

21 "handlebars": "^4.0.12",	21 "handlebars": "^4.0.12",

22 "jimp": "^0.3.11",	22 "jimp": "^0.3.11",

23 "ncp": "^2.0.0",	23 "ncp": "^2.0.0",

24 "mocha": "^5.2.0",	24 "mocha": "^5.2.0",

25 "selenium-webdriver": "4.0.0-alpha1",	25 "selenium-webdriver": "^4.0.0-alpha",
Sebastian Noack 2018/11/06 09:02:33 We might want to require ^4.0.0-alpha here. We might want to require ^4.0.0-alpha here. tlucas 2018/11/07 08:57:16 If not, there's still a typo: 4.0.0-alpha.1 Show quoted text On 2018/11/06 09:02:33, Sebastian Noack wrote: > We might want to require ^4.0.0-alpha here. If not, there's still a typo: 4.0.0-alpha.1 ^ hub 2018/11/07 17:13:36 I had started with that but I'm wondering of the A Show quoted text On 2018/11/06 09:02:33, Sebastian Noack wrote: > We might want to require ^4.0.0-alpha here. I had started with that but I'm wondering of the API stability in the alpha series. I'd hate that `alpha.2` break API. hub 2018/11/07 17:13:36 oops. Show quoted text On 2018/11/07 08:57:16, tlucas wrote: > On 2018/11/06 09:02:33, Sebastian Noack wrote: > > We might want to require ^4.0.0-alpha here. > > If not, there's still a typo: 4.0.0-alpha.1 > ^ oops.
26 "sign-addon": "^0.3.1"	26 "sign-addon": "^0.3.1"

27 },	27 },

28 "scripts": {	28 "scripts": {

29 "pretest": "bash -c \"python ensure_dependencies.py\"",	29 "pretest": "bash -c \"python ensure_dependencies.py\"",

30 "lint": "eslint *.js lib/ qunit/ ext/ test/ build/",	30 "lint": "eslint *.js lib/ qunit/ ext/ test/ build/",

31 "test-only": "mocha",	31 "test-only": "mocha",

32 "test": "npm run test-only --",	32 "test": "npm run test-only --",

33 "posttest": "npm run lint",	33 "posttest": "npm run lint",

34 "publish": "node build/publish.js"	34 "publish": "node build/publish.js"

35 }	35 }

36 }	36 }

LEFT	RIGHT