test/browsers/firefox.js - Issue 29938555: Noissue - Upgrade to selenium-webdriver 4.0.0-alpha

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: test/browsers/firefox.js

Issue 29938555: Noissue - Upgrade to selenium-webdriver 4.0.0-alpha (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Left Patch Set: Created Nov. 6, 2018, 8:32 a.m.

Right Patch Set: Renamed loc to rect Created Nov. 9, 2018, 10:26 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-present eyeo GmbH	3 * Copyright (C) 2006-present eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 21 matching lines...) Expand all Loading...
32 exports.ensureBrowser = ensureFirefox;	32 exports.ensureBrowser = ensureFirefox;

33	33

34 exports.getDriver = function(browserBinary, devenvPath)	34 exports.getDriver = function(browserBinary, devenvPath)

35 {	35 {

36 let options = new firefox.Options().setBinary(browserBinary).headless();	36 let options = new firefox.Options().setBinary(browserBinary).headless();

37 let driver = new webdriver.Builder()	37 let driver = new webdriver.Builder()

38 .forBrowser("firefox")	38 .forBrowser("firefox")

39 .setFirefoxOptions(options)	39 .setFirefoxOptions(options)

40 .build();	40 .build();

41	41

42 let cmd = new Command("install addon")	42 driver.execute(new Command("install addon")

43 .setParameter("path", devenvPath)	43 .setParameter("path", devenvPath)
Sebastian Noack 2018/11/06 09:02:33 Nit: The indentation seems to be off here by 2 spa Nit: The indentation seems to be off here by 2 spaces. hub 2018/11/07 17:13:37 Done. Show quoted text On 2018/11/06 09:02:33, Sebastian Noack wrote: > Nit: The indentation seems to be off here by 2 spaces. Done.
44 .setParameter("temporary", true);	44 .setParameter("temporary", true));

45

46 driver.execute(cmd);
Sebastian Noack 2018/11/06 09:02:33 Nit: I think we don't need the cmd variable anymor Nit: I think we don't need the cmd variable anymore (previously it was referenced twice, now it could be inlined). hub 2018/11/07 17:13:37 Done. Show quoted text On 2018/11/06 09:02:33, Sebastian Noack wrote: > Nit: I think we don't need the cmd variable anymore (previously it was > referenced twice, now it could be inlined). Done.
47	45

48 return driver;	46 return driver;

49 };	47 };

LEFT	RIGHT