Noissue - Upgrade to selenium-webdriver 4.0.0-alpha

test/wrappers/pages.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 49 matching lines @@
   return element.takeScreenshot().then(
     imageFromBase64,
 
     // Chrome doesn't support taking screenshots of individual elements. So as
     // a workaround, we scroll to the position of the element, take a screenshot
     // of the viewport and crop it to the size and position of our element.
     // This is not guaranteed to work on other browsers (mostly because
     // the behavior of Driver.takeScreenshot() may vary across browsers).
     () =>
       lastScreenshot = Promise.all([element.getRect(),
-                                    lastScreenshot]).then(([loc]) =>

[hub, 2018/11/09 22:23:31]

you might have taken the wrong version of the patch to rebase on, as this was
supposed to be `rect` instead of `loc` (as per your suggestion in the review)

[Sebastian Noack, 2018/11/09 22:26:53]

Oops, I indeed missed your last patch set. Fixed.

+                                    lastScreenshot]).then(([rect]) =>
         element.getDriver().executeScript(`
-          window.scrollTo(${loc.x}, ${loc.y});
+          window.scrollTo(${rect.x}, ${rect.y});
           return [window.scrollX, window.scrollY];
         `).then(result =>
         {
-          let x = loc.x - result[0];
-          let y = loc.y - result[1];
+          let x = rect.x - result[0];
+          let y = rect.y - result[1];
 
           return element.getDriver().takeScreenshot()
             .then(imageFromBase64)
-            .then(img => img.crop(x, y, loc.width, loc.height));
+            .then(img => img.crop(x, y, rect.width, rect.height));
         })
       )
   ).then(img => img.bitmap);
 }
 
 function getSections(driver)
 {
   return driver.findElements(By.css("section")).then(elements =>
     Promise.all(elements.map(e =>
       Promise.all([
@@ skipping 155 matching lines @@
         `)
       ).then(([added, err]) =>
       {
         if (err)
           throw err;
         assert.ok(added, "subscription added");
       })
     )
   );
 });