Unified Diff: test/browsers/firefox.js
Issue 29938555:
Noissue - Upgrade to selenium-webdriver 4.0.0-alpha (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Fix typo in package version
Created Nov. 7, 2018, 5:13 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« package.json ('K')
|
« package.json ('k')
|
test/wrappers/pages.js » ('j')
|
test/wrappers/pages.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/browsers/firefox.js |
| =================================================================== |
| --- a/test/browsers/firefox.js |
| +++ b/test/browsers/firefox.js |
| @@ -28,29 +28,20 @@ |
| require("geckodriver"); |
| exports.platform = "gecko"; |
| exports.oldestCompatibleVersion = "57.0"; |
| exports.ensureBrowser = ensureFirefox; |
| exports.getDriver = function(browserBinary, devenvPath) |
| { |
| - let options = new firefox.Options(); |
| - options.setBinary(browserBinary); |
| - options.headless(); |
| - |
| + let options = new firefox.Options().setBinary(browserBinary).headless(); |
| let driver = new webdriver.Builder() |
| .forBrowser("firefox") |
| .setFirefoxOptions(options) |
| .build(); |
| - let cmd = new Command("moz-install-web-ext") |
| + driver.execute(new Command("install addon") |
| .setParameter("path", devenvPath) |
| - .setParameter("temporary", true); |
| - |
| - driver.getExecutor().defineCommand( |
| - cmd.getName(), "POST", |
| - "/session/:sessionId/moz/addon/install" |
| - ); |
| - driver.schedule(cmd, `installWebExt(${devenvPath})`); |
| + .setParameter("temporary", true)); |
| return driver; |
| }; |
« package.json ('K')
|
« package.json ('k')
|
test/wrappers/pages.js » ('j')
|
test/wrappers/pages.js » ('J')
