Issue 7116 Run browser test in Microsoft Edge

test/runners/edge_process.js

 /*

[geo, 2018/11/08 22:13:34]

This is a new file.

  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-/**
- * @fileOverview This component manages listeners and calls them to distribute
- * messages about filter changes.
- */
+const edge = require("selenium-webdriver/edge");
 

[Sebastian Noack, 2018/11/09 19:13:43]

Nit: The blank line here seems superfluous.

[geo, 2018/11/09 19:45:09]

Done.

-const {EventEmitter} = require("./events");
+const {executeScript} = require("./webdriver");
 
-/**
- * This object allows registering and triggering listeners for filter events.
- * @type {EventEmitter}
- */
-let filterNotifier = new EventEmitter();
+function runScript(script, scriptName, scriptArgs)
+{
+  let service = new edge.ServiceBuilder()
+      .addArguments("--jwp")

[Sebastian Noack, 2018/11/09 19:13:43]

Mind adding a comment why that is necessary, and that it should be removed once
we update to Selenium Webdriver 4.0.

[geo, 2018/11/09 19:45:09]

Done.

+      .build();
+  let options = new edge.Options();
 
-exports.filterNotifier = filterNotifier;
+  let driver = edge.Driver.createSession(options, service);
+
+  return executeScript(driver, "Microsoft Edge (WebDriver)",
+                       script, scriptName, scriptArgs);
+}
+
+module.exports = function(script, scriptName, ...scriptArgs)
+{
+  return runScript(script, scriptName, scriptArgs)
+    .then(result => result)
+    .catch(error =>
+    {
+      throw error;
+    });

[Sebastian Noack, 2018/11/09 19:13:43]

What is the purpose of the then() and catch() calls here? They seem redundant.

[geo, 2018/11/09 19:45:09]

Done.

+};