Issue 29941694: Noissue - Fix *_BINARY=installed after update to selenium-webdriver 4.0

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29941694: Noissue - Fix *_BINARY=installed after update to selenium-webdriver 4.0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 months, 2 weeks ago by Sebastian Noack

Modified:
9 months, 1 week ago

Reviewers:
hub

CC:
tlucas

Visibility:
Public.

Noissue - Fix *_BINARY=installed after update to selenium-webdriver 4.0

Created: 9 months, 2 weeks ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	test/all.js	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/browsers/chromium.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	test/browsers/firefox.js	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 2

Sebastian Noack

Previously, passing in an empty string was equivalent to not setting the binary path. However, ...

9 months, 2 weeks ago (2018-11-10 03:16:16 UTC) #1

LGTM