Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(212)

Issue 29941694: Noissue - Fix *_BINARY=installed after update to selenium-webdriver 4.0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year ago by Sebastian Noack
Modified:
1 year ago
Reviewers:
hub
CC:
tlucas
Visibility:
Public.

Description

Noissue - Fix *_BINARY=installed after update to selenium-webdriver 4.0

Patch Set 1 #

Patch Set 2 : Fixed unrelated typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M test/all.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/browsers/chromium.js View 1 chunk +3 lines, -1 line 0 comments Download
M test/browsers/firefox.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2
Sebastian Noack
Previously, passing in an empty string was equivalent to not setting the binary path. However, ...
1 year ago (2018-11-10 03:16:16 UTC) #1
hub
1 year ago (2018-11-10 04:31:14 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5