Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29941694: Noissue - Fix *_BINARY=installed after update to selenium-webdriver 4.0 (Closed)

Created:
Nov. 10, 2018, 3:14 a.m. by Sebastian Noack
Modified:
Nov. 12, 2018, 9:18 p.m.
Reviewers:
hub
CC:
tlucas
Visibility:
Public.

Description

Noissue - Fix *_BINARY=installed after update to selenium-webdriver 4.0

Patch Set 1 #

Patch Set 2 : Fixed unrelated typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M test/all.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/browsers/chromium.js View 1 chunk +3 lines, -1 line 0 comments Download
M test/browsers/firefox.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2
Sebastian Noack
Previously, passing in an empty string was equivalent to not setting the binary path. However, ...
Nov. 10, 2018, 3:16 a.m. (2018-11-10 03:16:16 UTC) #1
hub
Nov. 10, 2018, 4:31 a.m. (2018-11-10 04:31:14 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld