Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/browsers/chromium.js

Issue 29941694: Noissue - Fix *_BINARY=installed after update to selenium-webdriver 4.0 (Closed)
Patch Set: Created Nov. 10, 2018, 3:14 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/all.js ('k') | test/browsers/firefox.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browsers/chromium.js
===================================================================
--- a/test/browsers/chromium.js
+++ b/test/browsers/chromium.js
@@ -39,10 +39,12 @@
exports.getDriver = function(browserBinary, devenvPath)
{
let options = new chrome.Options()
- .setChromeBinaryPath(browserBinary)
.addArguments("--no-sandbox")
.addArguments(`load-extension=${devenvPath}`);
+ if (browserBinary != null)
+ options.setChromeBinaryPath(browserBinary);
+
return new webdriver.Builder()
.forBrowser("chrome")
.setChromeOptions(options)
« no previous file with comments | « test/all.js ('k') | test/browsers/firefox.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld