Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/filterStorage.js

Issue 29946572: Issue 7094 - Keep subscription filters by text only (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Fix bug Created Nov. 19, 2018, 2:28 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/filterStorage.js
===================================================================
--- a/test/filterStorage.js
+++ b/test/filterStorage.js
@@ -488,29 +488,29 @@
compareFilterSubscriptions(test, "filter3 subscriptions after adding http://test2/", filter3, [subscription2]);
filterStorage.removeSubscription(subscription1);
compareFilterSubscriptions(test, "filter1 subscriptions after removing http://test1/", filter1, []);
compareFilterSubscriptions(test, "filter2 subscriptions after removing http://test1/", filter2, [subscription2]);
compareFilterSubscriptions(test, "filter3 subscriptions after removing http://test1/", filter3, [subscription2]);
- filterStorage.updateSubscriptionFilters(subscription3, [filter3]);
+ filterStorage.updateSubscriptionFilters(subscription3, [filter3.text]);
compareFilterSubscriptions(test, "filter1 subscriptions after updating http://test3/ filters", filter1, []);
compareFilterSubscriptions(test, "filter2 subscriptions after updating http://test3/ filters", filter2, [subscription2]);
compareFilterSubscriptions(test, "filter3 subscriptions after updating http://test3/ filters", filter3, [subscription2]);
filterStorage.addSubscription(subscription3);
compareFilterSubscriptions(test, "filter1 subscriptions after adding http://test3/", filter1, []);
compareFilterSubscriptions(test, "filter2 subscriptions after adding http://test3/", filter2, [subscription2]);
compareFilterSubscriptions(test, "filter3 subscriptions after adding http://test3/", filter3, [subscription2, subscription3]);
- filterStorage.updateSubscriptionFilters(subscription3, [filter1, filter2]);
+ filterStorage.updateSubscriptionFilters(subscription3, [filter1.text, filter2.text]);
compareFilterSubscriptions(test, "filter1 subscriptions after updating http://test3/ filters", filter1, [subscription3]);
compareFilterSubscriptions(test, "filter2 subscriptions after updating http://test3/ filters", filter2, [subscription2, subscription3]);
compareFilterSubscriptions(test, "filter3 subscriptions after updating http://test3/ filters", filter3, [subscription2]);
filterStorage.removeSubscription(subscription3);
compareFilterSubscriptions(test, "filter1 subscriptions after removing http://test3/", filter1, []);
« lib/filterListener.js ('K') | « test/filterListener.js ('k') | test/subscriptionClasses.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld