lib/iniParser.js - Issue 29946572: Issue 7094 - Keep subscription filters by text only

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/iniParser.js

Issue 29946572: Issue 7094 - Keep subscription filters by text only (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Rebase Created Feb. 16, 2019, 3:10 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/iniParser.js

===================================================================

--- a/lib/iniParser.js

+++ b/lib/iniParser.js

@@ -102,21 +102,17 @@

case "subscription filters":

if (this.subscriptions.length)

{

let currentSubscription = this.subscriptions[

this.subscriptions.length - 1

];

for (let text of this._curObj)

- {

- let filter = Filter.fromText(text);

- currentSubscription.addFilter(filter);

- filter.addSubscription(currentSubscription);

- }

+ currentSubscription.addFilterText(text);

}

break;

}

if (line === null)

return;

« no previous file with comments | « lib/filterStorage.js ('k') | lib/subscriptionClasses.js » ('j') | no next file with comments »