Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/synchronizer.js

Issue 29946572: Issue 7094 - Keep subscription filters by text only (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Rebase Created Feb. 16, 2019, 3:10 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/subscriptionClasses.js ('k') | test/filterListener.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/synchronizer.js
===================================================================
--- a/lib/synchronizer.js
+++ b/lib/synchronizer.js
@@ -254,25 +254,25 @@
if (minVersion)
subscription.requiredVersion = minVersion;
else
delete subscription.requiredVersion;
// Process filters
lines.shift();
- let filters = [];
+ let filterText = [];
for (let line of lines)
{
line = Filter.normalize(line);
if (line)
- filters.push(Filter.fromText(line));
+ filterText.push(line);
}
- filterStorage.updateSubscriptionFilters(subscription, filters);
+ filterStorage.updateSubscriptionFilters(subscription, filterText);
}
_onDownloadError(downloadable, downloadURL, error, channelStatus,
responseStatus, redirectCallback)
{
let subscription = Subscription.fromURL(downloadable.url);
subscription.lastDownload = Math.round(Date.now() / MILLIS_IN_SECOND);
subscription.downloadStatus = error;
« no previous file with comments | « lib/subscriptionClasses.js ('k') | test/filterListener.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld