Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(80)

Issue 29947559: Issue 7114 - Remove az and untranslated resources from Windows packages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by Sebastian Noack
Modified:
1 year, 3 months ago
Reviewers:
geo, tlucas
Visibility:
Public.

Description

Issue 7114 - Remove az and untranslated resources from Windows packages

Patch Set 1 #

Patch Set 2 : Different approach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M packagerEdge.py View 1 1 chunk +14 lines, -0 lines 0 comments Download
M tests/expecteddata/AppxManifest_edge_development_build.xml View 1 1 chunk +0 lines, -2 lines 0 comments Download
M tests/expecteddata/AppxManifest_edge_release_build.xml View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
Geo, can you try the following? 1. Apply the patch to adblockpluschrome/buildtools 2. Run "build.py ...
1 year, 3 months ago (2018-11-20 01:55:46 UTC) #1
Sebastian Noack
On 2018/11/20 01:55:46, Sebastian Noack wrote: > 2. Run "build.py build -t edge" For got ...
1 year, 3 months ago (2018-11-20 03:07:42 UTC) #2
geo
On 2018/11/20 03:07:42, Sebastian Noack wrote: > On 2018/11/20 01:55:46, Sebastian Noack wrote: > > ...
1 year, 3 months ago (2018-11-20 19:50:41 UTC) #3
Sebastian Noack
As per the discussion on IRC, it seems that the package doesn't install either if ...
1 year, 3 months ago (2018-11-20 21:35:53 UTC) #4
geo
1 year, 3 months ago (2018-11-21 18:29:02 UTC) #5
On 2018/11/20 21:35:53, Sebastian Noack wrote:
> As per the discussion on IRC, it seems that the package doesn't install either
> if it has any localized resources for the 'az' locale (renaming it to az-latn
> works but then the translation isn't picked up either, so we can as well just
> remove it), or if the manifest lists the 'uz' locale without providing a
> translation for the description.
> 
> In order to keep things simple and as consistent as possible, I uploaded a new
> patch that removes the "Resources/az" folder, and then removes every
<Resource>
> element from appxmanifest.xml that doesn't have a corresponding subfolder
under
> "Resources".
> 
> Can you test again with the new patch? Thanks.

LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5