tests/expected_output/relative/de/rel_path - Issue 29947567: Issue 5333 - Ensure links in metadata and in most tags can be made relative

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: tests/expected_output/relative/de/rel_path

Issue 29947567: Issue 5333 - Ensure links in metadata and in most tags can be made relative (Closed) Base URL: https://hg.adblockplus.org/cms/

Patch Set: Address comments on PS1 Created Nov. 21, 2018, 4:29 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
	1 {{ head\|safe }}
	Vasily Kuznetsov 2018/11/21 23:30:47 So what's happening here is that split_head_body() So what's happening here is that split_head_body() extracts the content of <head> tag into `head`, removes the tag itself and the rest comes here as `body`. If we want to produce a reasonable HTML on the output, one approach that can work is to move <!DOCTYPE> and <html> tags into the template and then include the head and the body into it: <!DOCTYPE html> <html> <head> {{ head \| safe }} ... more head stuff from template, maybe some links ... </head> {{ body \| safe }} </html> The page would then have those two tags at the top level without anything around them: <head> ... head stuff ... </head> <body> ... body stuff ... </body> Something like this should do. rhowell 2018/12/19 02:33:30 Done. Show quoted text On 2018/11/21 23:30:47, Vasily Kuznetsov wrote: > So what's happening here is that split_head_body() extracts the content of > <head> tag into `head`, removes the tag itself and the rest comes here as > `body`. If we want to produce a reasonable HTML on the output, one approach that > can work is to move <!DOCTYPE> and <html> tags into the template and then > include the head and the body into it: > > <!DOCTYPE html> > <html> > <head> > {{ head \| safe }} > ... more head stuff from template, maybe some links ... > </head> > {{ body \| safe }} > </html> > > The page would then have those two tags at the top level without anything > around them: > > <head> > ... head stuff ... > </head> > <body> > ... body stuff ... > </body> > > Something like this should do. Done.
	2 <title>Page Title</title>

	3 <link rel="stylesheet" href="../dist/css/main.min.css">

	4 <base href="https://www.example.com/news/index.html">

	5 <script src="../scripts/myscript.js"></script>

	6

	7

	8

	9 <!DOCTYPE html>

1 <html>	10 <html>

	11

	12

2 <body>	13 <body>

3 Simple TS with default: Übersetzen.	14 Simple TS with default: Übersetzen.

4 Same TS with no default: Übersetzen.	15 Same TS with no default: Übersetzen.

5 Nested translation: <a href="http://bar.de/">Bar</a> und <a href="http://baz.de/ ">Baz</a>.	16 Nested translation: <a href="http://bar.de/">Bar</a> und <a href="http://baz.de/ ">Baz</a>.

6 Link resolving: <a href="translate" hreflang="de">Diese Seite</a>.	17 Link resolving: <a href="translate" hreflang="de">Diese Seite</a>.

7 Link to a non-translatable page: <a href="../en/sitemap" hreflang="en">Seitenver zeichnis</a>.	18 Link to a non-translatable page: <a href="../en/sitemap" hreflang="en">Seitenver zeichnis</a>.

8 Entity escaping in links: <a href="http://foo.com/?a&b">Bar</a>.	19 Entity escaping in links: <a href="http://foo.com/?a&b">Bar</a>.

9 Image link: <img src="../img/icon"></img>	20 Image link: <img src="../img/icon"></img>

	21 Iframe link: <iframe src="../default.asp"></iframe>

	22 Script link: <script src="myscripts.js"></script>

	23 Input link: <input type="image" src="../img/submit.gif" alt="Submit">

10 Link to external source: <a href="http://bar.de/">Bar</a>	24 Link to external source: <a href="http://bar.de/">Bar</a>

11 Link to self: <a href="rel_path" hreflang="de">	25 Link to self: <a href="rel_path" hreflang="de">

12 Link to self with extension: <a href="rel_path.html" hreflang="de">	26 Link to self with extension: <a href="rel_path.html" hreflang="de">

13 Relative link to local page: <a href="../en/sitemap">	27 Relative link to local page: <a href="../en/sitemap">

14 Absolute link to local page: <a href="../en/sitemap">	28 Absolute link to local page: <a href="../en/sitemap">

15 Relative link to different locale: <a href="../de/sitemap">	29 Relative link to different locale: <a href="../de/sitemap">

16 Absolute link to diferent locale: <a href="sitemap">	30 Absolute link to diferent locale: <a href="sitemap">

17 Relative link to page in subfolder: <a href="../foo/bar">	31 Relative link to page in subfolder: <a href="../foo/bar">

18 Absolute link to page in subfolder: <a href="../foo/bar">	32 Absolute link to page in subfolder: <a href="../foo/bar">

	33 Resource URL: <link rel="stylesheet" href="../dist/css/main.min.css">

19 </body>	34 </body>

20 </html>	35 </html>

OLD	NEW

« no previous file with comments | « cms/converters.py ('k') | tests/expected_output/relative/en/rel_path » ('j') | tests/test_site/pages/rel_path.html » ('J')