Issue 7093 - Only animate icon for global notifications

lib/notificationHelper.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 22 matching lines @@
 let defaultDisplayMethods = ["popup"];
 let displayMethods = Object.create(null);
 displayMethods.critical = ["icon", "notification", "popup"];
 displayMethods.question = ["notification"];
 displayMethods.normal = ["notification"];
 displayMethods.relentless = ["notification"];
 displayMethods.information = ["icon", "popup"];
 
 function prepareNotificationIconAndPopup()
 {
-  let animateIcon = shouldDisplay("icon", activeNotification.type);
+  let animateIcon = !(activeNotification.urlFilters instanceof Array) &&

[kzar, 2018/11/20 20:20:42]

Nit: I figure we could just check that `urlFilters` is truthy instead of an
Array instance, but I don't insist.

[Thomas Greiner, 2018/11/21 11:55:58]

You're probably right. Given that this data is coming from the server, I'm not
sure I trust it enough with getting the format right though. :)

+      shouldDisplay("icon", activeNotification.type);
   activeNotification.onClicked = () =>
   {
     if (animateIcon)
       stopIconAnimation();
     notificationClosed();
   };
   if (animateIcon)
     startIconAnimation(activeNotification.type);
 }
 
@@ skipping 256 matching lines @@
   if (activeNotification)
     activeNotification.onClicked();
 };
 
 ext.pages.onLoading.addListener(page =>
 {
   NotificationStorage.showNext(page.url.href);
 });
 
 NotificationStorage.addShowListener(showNotification);