metadata.chrome - Issue 29953557: Issue 7145 - Change chrome extension name for cws

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: metadata.chrome

Issue 29953557: Issue 7145 - Change chrome extension name for cws (Closed)

Patch Set: Created Nov. 28, 2018, 3:45 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 [general]	1 [general]

2 basename = adblockpluschrome	2 basename = adblockpluschrome

3 version = 3.4.1	3 version = 3.4.1

4 author = eyeo GmbH	4 author = eyeo GmbH

5 backgroundScripts = polyfill.js	5 backgroundScripts = polyfill.js

6 ext/common.js	6 ext/common.js

7 ext/background.js	7 ext/background.js

8 lib/compat.js	8 lib/compat.js

9 lib/publicSuffixList.js	9 lib/publicSuffixList.js

10 lib/adblockplus.js	10 lib/adblockplus.js

(...skipping 13 matching lines...) Expand all Loading...
24 icons/abp-40.png	24 icons/abp-40.png

25 popup.html	25 popup.html

26 icons =	26 icons =

27 icons/abp-16.png	27 icons/abp-16.png

28 icons/abp-32.png	28 icons/abp-32.png

29 icons/detailed/abp-48.png	29 icons/detailed/abp-48.png

30 icons/detailed/abp-64.png	30 icons/detailed/abp-64.png

31 icons/detailed/abp-128.png	31 icons/detailed/abp-128.png

32	32

33 [manifest]	33 [manifest]

	34 name = __MSG_name_chrome__
	kzar 2018/11/28 16:01:34 So this string already exists somewhere (where?), So this string already exists somewhere (where?), and doesn't need to be added at the same time as we make this change? wspee 2018/11/28 16:10:58 Yes and yes. For the string see #7146. I would say Show quoted text On 2018/11/28 16:01:34, kzar wrote: > So this string already exists somewhere (where?), and doesn't need to be added > at the same time as we make this change? Yes and yes. For the string see #7146. I would say it's best we include this in the dependency update that would land #7146. If you prefer we could also land a separate dependency update with just 7146/7145 but that would be more work for us (one additional dependency update)?
34 devtools_page = devtools.html	35 devtools_page = devtools.html

35 storage.managed_schema = managed-storage-schema.json	36 storage.managed_schema = managed-storage-schema.json

36 permissions =	37 permissions =

37 tabs	38 tabs

38 <all_urls>	39 <all_urls>

39 contextMenus	40 contextMenus

40 webRequest	41 webRequest

41 webRequestBlocking	42 webRequestBlocking

42 webNavigation	43 webNavigation

43 storage	44 storage

(...skipping 126 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
170 adblockplusui/locale//common.json =	171 adblockplusui/locale//common.json =

171 adblockplusui/locale//composer.json =	172 adblockplusui/locale//composer.json =

172 adblockplusui/locale//desktop-options.json =	173 adblockplusui/locale//desktop-options.json =

173 adblockplusui/locale//filter-validation.json =	174 adblockplusui/locale//filter-validation.json =

174 adblockplusui/locale//first-run.json =	175 adblockplusui/locale//first-run.json =

175 adblockplusui/locale//issue-reporter.json =	176 adblockplusui/locale//issue-reporter.json =

176 adblockplusui/locale//manifest.json =	177 adblockplusui/locale//manifest.json =

177 adblockplusui/locale//notification-helper.json =	178 adblockplusui/locale//notification-helper.json =

178 adblockplusui/locale//popup.json =	179 adblockplusui/locale//popup.json =

179 adblockplusui/locale//updates.json =	180 adblockplusui/locale//updates.json =

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »