Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/runners/firefox_process.js

Issue 29954557: Noissue - Update selenium-webdriver to 4.0.0-alpha (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Nov. 29, 2018, 3:12 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « package.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runners/firefox_process.js
===================================================================
--- a/test/runners/firefox_process.js
+++ b/test/runners/firefox_process.js
@@ -25,22 +25,17 @@
const {ensureFirefox} = require("./firefox_download");
// Firefox 57 seems to be the minimum to reliably run with WebDriver
// on certain system configurations like Debian 9, TravisCI.
const FIREFOX_VERSION = "57.0";
function runScript(firefoxPath, script, scriptName, scriptArgs)
{
- let binary = new firefox.Binary(firefoxPath);
- binary.addArguments("-headless");
-
- const options = new firefox.Options()
- .setBinary(binary);
-
+ const options = new firefox.Options().setBinary(firefoxPath).headless();
const driver = new Builder()
.forBrowser("firefox")
.setFirefoxOptions(options)
.build();
return executeScript(driver, "Firefox", script, scriptName, scriptArgs);
}
« no previous file with comments | « package.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld