Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: ext/background.js

Issue 29958567: Issue 7104 - Clear style sheets when frame structure is updated (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Left Patch Set: Use state object (includes rebase) Created Dec. 18, 2018, 4:32 p.m.
Right Patch Set: Update comment Created Dec. 19, 2018, 1:47 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | lib/contentFiltering.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 framesOfTabs.set(tabId, frames); 126 framesOfTabs.set(tabId, frames);
127 } 127 }
128 128
129 let frame = frames.get(frameId); 129 let frame = frames.get(frameId);
130 if (!frame) 130 if (!frame)
131 { 131 {
132 frame = {}; 132 frame = {};
133 frames.set(frameId, frame); 133 frames.set(frameId, frame);
134 } 134 }
135 135
136 frame.state = {}; 136 frame.state = Object.create(null);
kzar 2018/12/19 10:22:00 Nit: How about `Object.create(null)`?
Manish Jethani 2018/12/19 13:03:54 Done.
137 137
138 return frame; 138 return frame;
139 } 139 }
140 140
141 function updatePageFrameStructure(frameId, tabId, url, parentFrameId) 141 function updatePageFrameStructure(frameId, tabId, url, parentFrameId)
142 { 142 {
143 if (frameId == 0) 143 if (frameId == 0)
144 { 144 {
145 let page = new Page({id: tabId, url}); 145 let page = new Page({id: tabId, url});
146 146
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
519 return frames.get(0) || null; 519 return frames.get(0) || null;
520 } 520 }
521 }; 521 };
522 } 522 }
523 523
524 return ext.onMessage._dispatch( 524 return ext.onMessage._dispatch(
525 message, sender, sendResponse 525 message, sender, sendResponse
526 ).includes(true); 526 ).includes(true);
527 }); 527 });
528 } 528 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld