Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29959567: Issue 7158 - Update subscriptions.xml to include Malay coverage with Indonesian (Closed)

Created:
Dec. 5, 2018, 1:33 p.m. by hub
Modified:
Dec. 6, 2018, 2:56 p.m.
Reviewers:
Manish Jethani, kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 7158 - Update subscriptions.xml to include Malay coverage with Indonesian (this file has been regenerated from the source, as usual)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/content/ui/subscriptions.xml View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 5
hub
Dec. 5, 2018, 1:33 p.m. (2018-12-05 13:33:39 UTC) #1
kzar
https://codereview.adblockplus.org/29959567/diff/29959568/chrome/content/ui/subscriptions.xml File chrome/content/ui/subscriptions.xml (right): https://codereview.adblockplus.org/29959567/diff/29959568/chrome/content/ui/subscriptions.xml#newcode29 chrome/content/ui/subscriptions.xml:29: specialization="Bahasa Indonesia, Melayu" I notice you spell it "Melayu" ...
Dec. 6, 2018, 11:20 a.m. (2018-12-06 11:20:33 UTC) #2
hub
https://codereview.adblockplus.org/29959567/diff/29959568/chrome/content/ui/subscriptions.xml File chrome/content/ui/subscriptions.xml (right): https://codereview.adblockplus.org/29959567/diff/29959568/chrome/content/ui/subscriptions.xml#newcode29 chrome/content/ui/subscriptions.xml:29: specialization="Bahasa Indonesia, Melayu" On 2018/12/06 11:20:33, kzar wrote: > ...
Dec. 6, 2018, 11:28 a.m. (2018-12-06 11:28:55 UTC) #3
kzar
On 2018/12/06 11:28:55, hub wrote: > > Technically it is subscriptionlist... OK, I'm just double ...
Dec. 6, 2018, 11:42 a.m. (2018-12-06 11:42:29 UTC) #4
kzar
Dec. 6, 2018, 2:41 p.m. (2018-12-06 14:41:33 UTC) #5
Arthur thinks it's correct, so LGTM.

Powered by Google App Engine
This is Rietveld