Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29961555: Issue 7162 - Add isWhitelisted method to CombinedMatcher (Closed)

Created:
Dec. 9, 2018, 11:54 a.m. by Manish Jethani
Modified:
Dec. 12, 2018, 8:13 a.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M lib/matcher.js View 1 chunk +13 lines, -0 lines 3 comments Download
M test/matcher.js View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
Dec. 9, 2018, 11:54 a.m. (2018-12-09 11:54:52 UTC) #1
Manish Jethani
Patch Set 1
Dec. 9, 2018, 11:57 a.m. (2018-12-09 11:57:31 UTC) #2
hub
https://codereview.adblockplus.org/29961555/diff/29961556/lib/matcher.js File lib/matcher.js (right): https://codereview.adblockplus.org/29961555/diff/29961556/lib/matcher.js#newcode443 lib/matcher.js:443: } do we use this anywhere?
Dec. 11, 2018, 1:59 p.m. (2018-12-11 13:59:55 UTC) #3
Manish Jethani
https://codereview.adblockplus.org/29961555/diff/29961556/lib/matcher.js File lib/matcher.js (right): https://codereview.adblockplus.org/29961555/diff/29961556/lib/matcher.js#newcode443 lib/matcher.js:443: } On 2018/12/11 13:59:54, hub wrote: > do we ...
Dec. 12, 2018, 12:48 a.m. (2018-12-12 00:48:06 UTC) #4
hub
Dec. 12, 2018, 7:27 a.m. (2018-12-12 07:27:09 UTC) #5
LGTM

https://codereview.adblockplus.org/29961555/diff/29961556/lib/matcher.js
File lib/matcher.js (right):

https://codereview.adblockplus.org/29961555/diff/29961556/lib/matcher.js#newc...
lib/matcher.js:443: }
On 2018/12/12 00:48:06, Manish Jethani wrote:
> On 2018/12/11 13:59:54, hub wrote:
> > do we use this anywhere?
> 
> We will call this function from lib/filterComposer.js in adblockpluschrome.

Acknowledged.

Powered by Google App Engine
This is Rietveld