Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 29965589: Issue 7181 - Keep a keyword-by-filter map after all (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months ago by Manish Jethani
Modified:
11 months ago
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

This reverts some part of the changes for this issue. Basically we need to remember the keyword by which a filter was added so we can remove it later by the same keyword. We also need to ensure that the same filter is not added twice. This will add again ~2 MB to the memory footprint for EasyList+AA. I'll try to think of a better way to do this, but this is it for now.

Patch Set 1 #

Patch Set 2 : Clear map #

Patch Set 3 : Rename to _keywordByFilter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M lib/matcher.js View 1 2 3 chunks +19 lines, -1 line 0 comments Download
M test/matcher.js View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Manish Jethani
11 months ago (2018-12-19 18:24:33 UTC) #1
Manish Jethani
Patch Set 1
11 months ago (2018-12-19 18:28:37 UTC) #2
kzar
LGTM
11 months ago (2018-12-20 10:15:41 UTC) #3
kzar
(But please remember to change issue number in commit message to #7181 before pushing.)
11 months ago (2018-12-20 10:16:10 UTC) #4
Manish Jethani
On 2018/12/20 10:16:10, kzar wrote: > (But please remember to change issue number in commit ...
11 months ago (2018-12-20 10:51:57 UTC) #5
Manish Jethani
Patch Set 2: Clear map Sorry, I forgot this part. We need to clear the ...
11 months ago (2018-12-20 11:01:07 UTC) #6
kzar
11 months ago (2018-12-20 11:10:24 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5