Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(420)

Issue 29968555: Issue 7145 - Change manifest name for release builds

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by wspee
Modified:
4 months, 4 weeks ago
Reviewers:
Sebastian Noack, tlucas
Visibility:
Public.

Description

Issue 7145 - Change manifest name for release builds

Patch Set 1 #

Patch Set 2 : Updated regexp in packagerEdge.py #

Patch Set 3 : Updated tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M packagerEdge.py View 1 1 chunk +1 line, -1 line 0 comments Download
M templates/manifest.json.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M tests/expecteddata/AppxManifest_edge_release_build.xml View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tests/expecteddata/manifest_chrome_devenv.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/expecteddata/manifest_chrome_release_build.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/expecteddata/manifest_edge_devenv.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/expecteddata/manifest_edge_release_build.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/expecteddata/manifest_gecko_devenv.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/expecteddata/manifest_gecko_release_build.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/test_packagerWebExt.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
Please adapt line 167 in packegerEdge.py. Otherwise, this change will break the builds for Microsoft ...
5 months ago (2018-12-27 21:48:02 UTC) #1
Sebastian Noack
On 2018/12/27 21:48:02, Sebastian Noack wrote: > Please adapt line 167 in packegerEdge.py. Otherwise, this ...
5 months ago (2018-12-28 04:49:24 UTC) #2
wspee
On 2018/12/28 04:49:24, Sebastian Noack wrote: > On 2018/12/27 21:48:02, Sebastian Noack wrote: > > ...
4 months, 4 weeks ago (2018-12-28 15:00:24 UTC) #3
Sebastian Noack
On 2018/12/28 15:00:24, wspee wrote: > For SEO purposes (i.e. rank higher for the term ...
4 months, 4 weeks ago (2018-12-28 21:17:46 UTC) #4
wspee
On 2018/12/28 21:17:46, Sebastian Noack wrote: > On 2018/12/28 15:00:24, wspee wrote: > > For ...
4 months, 4 weeks ago (2018-12-29 17:05:11 UTC) #5
Sebastian Noack
4 months, 4 weeks ago (2018-12-29 17:17:40 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5