Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(261)

Issue 29968558: Issue 7037 - [XTM Integration] Make REST API url customizable

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 3 weeks ago by Tudor Avram
Modified:
1 day, 21 hours ago
Reviewers:
Vasily Kuznetsov
CC:
wspee
Visibility:
Public.

Description

Issue 7037 - [XTM Integration] Make REST API url customizable

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Patch Set 3 : Removed unnecessary print statements #

Patch Set 4 : Removed one more print statement #

Patch Set 5 : Merged with changes from 7039 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -38 lines) Patch
M cms/translations/xtm/cli.py View 1 2 3 4 4 chunks +9 lines, -6 lines 0 comments Download
M cms/translations/xtm/constants.py View 1 2 3 4 3 chunks +4 lines, -0 lines 0 comments Download
M cms/translations/xtm/utils.py View 2 chunks +39 lines, -0 lines 0 comments Download
M cms/translations/xtm/xtm_api.py View 2 3 4 11 chunks +27 lines, -12 lines 0 comments Download
M tests/test_xtm_api.py View 8 chunks +10 lines, -8 lines 0 comments Download
M tests/test_xtm_translate.py View 1 2 3 4 5 chunks +8 lines, -8 lines 0 comments Download
M tests/test_xtm_translations_utils.py View 6 chunks +24 lines, -4 lines 0 comments Download
M tests/utils.py View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M tests/xtm_conftest.py View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Tudor Avram
Hi Vasily and Winsley, I changed the implementation of the XTM integration to support customisation ...
8 months, 3 weeks ago (2018-12-27 14:25:36 UTC) #1
Vasily Kuznetsov
Hi Tudor, This looks pretty good. I just have one question (see below). Cheers, Vasily ...
8 months, 1 week ago (2019-01-10 17:45:23 UTC) #2
Tudor Avram
Hi Vasily, Addressed your comments, sorry for the delay :D Tudor. https://codereview.adblockplus.org/29968558/diff/29968559/cms/translations/xtm/cli.py File cms/translations/xtm/cli.py (right): ...
2 days ago (2019-09-17 12:25:02 UTC) #3
Tudor Avram
Hi Vasily, Updated with a new patch that has the changes from 7039. Let me ...
1 day, 23 hours ago (2019-09-17 13:39:08 UTC) #4
Vasily Kuznetsov
1 day, 21 hours ago (2019-09-17 16:06:47 UTC) #5
On 2019/09/17 13:39:08, Tudor Avram wrote:
> Hi Vasily, 
> 
> Updated with a new patch that has the changes from 7039. Let me know if you
have
> any questions, thanks!
> 
> Tudor

Allright. LGTM. Thank you for working on this!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5