tox.ini - Issue 29968569: Issue 4014 - Publish python-abp on PyPI

Delta Between Two Patch Sets: tox.ini

Issue 29968569: Issue 4014 - Publish python-abp on PyPI (Closed) Base URL: https://hg.adblockplus.org/python-abp/

Left Patch Set: Created Dec. 27, 2018, 11:31 p.m.

Right Patch Set: Address comment on PS5 Created Jan. 3, 2019, 9:32 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [tox]	1 [tox]

2 envlist = py27,py35,py36,pypy,coverage2,coverage3,flake8	2 envlist = py27,py35,py36,pypy,flake8

3	3

4 [flake8]	4 [flake8]

5 ignore = D107, N801, W503	5 ignore = D107, N801, W503

6	6

7 [testenv]	7 [testenv]

8 deps =	8 deps =

9 pytest	9 pytest-cov

10 mock	10 mock

11 commands =	11 commands =

12 py.test tests	12 # For accurate coverage reports, we write a `pragma: no py{}` instruction

	13 # containing the current Python version to a .coveragerc file

	14 python -c 'import sys; open(".coveragerc", "w").write("[report]\nexclude_lin es = pragma: no py\{\} cover".format(sys.version_info[0]))'

	15 py.test --cov=abp --cov-report=term-missing --cov-fail-under=100 tests

13	16

14 # We have to install our package in development mode so that pytest-cov can	17 # We have to install our package in development mode so that pytest-cov can

15 # find the .coverage and .coveragerc files.	18 # find the .coverage and .coveragerc files.

16 usedevelop = true	19 usedevelop = true

17

18 [testenv:coverage2]

19 basepython = python2

20 setenv = PY_VER = 2

21 deps =

22 pytest-cov

23 mock

24 commands =

25 py.test --cov=abp --cov-report=term-missing tests

26

27 [testenv:coverage3]
Sebastian Noack 2018/12/28 00:22:51 What's the point of using a separate environment f What's the point of using a separate environment for coverage, if you want to run coverage for both Python 2 and 3 anyway? rhowell 2018/12/28 21:50:08 By default, tox only checks coverage for the versi Show quoted text On 2018/12/28 00:22:51, Sebastian Noack wrote: > What's the point of using a separate environment for coverage, if you want to > run coverage for both Python 2 and 3 anyway? By default, tox only checks coverage for the version of Python that is the current default on the local system. Seems like it would be best to check both Python 2 & 3. But, I ran into an error trying to change the basepython variable in one environment: py._vendored_packages.iniconfig.ParseError: tox.ini:26: duplicate name 'basepython' This was a fairly quick & dirty work-around. I did some research, but wasn't able to find a better way yet, though this article was very informative: https://anonbadger.wordpress.com/2017/11/24/better-unittest-coverage-stats-ex... I'm open for discussion or suggestions on this, though. Sebastian Noack 2018/12/28 22:39:02 If you just run coverage reports for every environ Show quoted text On 2018/12/28 21:50:08, rhowell wrote: > On 2018/12/28 00:22:51, Sebastian Noack wrote: > > What's the point of using a separate environment for coverage, if you want to > > run coverage for both Python 2 and 3 anyway? > > By default, tox only checks coverage for the version of Python that is the > current default on the local system. Seems like it would be best to check both > Python 2 & 3. But, I ran into an error trying to change the basepython variable > in one environment: > > py._vendored_packages.iniconfig.ParseError: tox.ini:26: duplicate name > 'basepython' > > This was a fairly quick & dirty work-around. I did some research, but wasn't > able to find a better way yet, though this article was very informative: > https://anonbadger.wordpress.com/2017/11/24/better-unittest-coverage-stats-ex... > > I'm open for discussion or suggestions on this, though. If you just run coverage reports for every environment you run tests on, you don't have to explicitly set the basepython setting. However, the tricky part is to get the Python major version into the .coveragerc. This should do the trick: [testenv] deps = pytest-cov mock commands = python -c 'import sys; open(".coveragerc", "w").write("[report]\nexclude_lines = pragma: no py{} cover".format(sys.version_info[0]))' py.test --cov=abp --cov-report=term-missing tests rhowell 2018/12/29 01:30:51 Done. Show quoted text On 2018/12/28 22:39:02, Sebastian Noack wrote: > On 2018/12/28 21:50:08, rhowell wrote: > > On 2018/12/28 00:22:51, Sebastian Noack wrote: > > > What's the point of using a separate environment for coverage, if you want > to > > > run coverage for both Python 2 and 3 anyway? > > > > By default, tox only checks coverage for the version of Python that is the > > current default on the local system. Seems like it would be best to check both > > Python 2 & 3. But, I ran into an error trying to change the basepython > variable > > in one environment: > > > > py._vendored_packages.iniconfig.ParseError: tox.ini:26: duplicate name > > 'basepython' > > > > This was a fairly quick & dirty work-around. I did some research, but wasn't > > able to find a better way yet, though this article was very informative: > > > https://anonbadger.wordpress.com/2017/11/24/better-unittest-coverage-stats-ex... > > > > I'm open for discussion or suggestions on this, though. > > If you just run coverage reports for every environment you run tests on, you > don't have to explicitly set the basepython setting. However, the tricky part is > to get the Python major version into the .coveragerc. This should do the trick: > > [testenv] > deps = > pytest-cov > mock > commands = > python -c 'import sys; open(".coveragerc", > "w").write("[report]\nexclude_lines = pragma: no py{} > cover".format(sys.version_info[0]))' > py.test --cov=abp --cov-report=term-missing tests Done.
28 basepython = python3

29 setenv = PY_VER = 3

30 deps =

31 pytest-cov

32 mock

33 commands =

34 py.test --cov=abp --cov-report=term-missing tests

35	20

36 [testenv:flake8]	21 [testenv:flake8]

37 basepython = python3	22 basepython = python3

38 skip_install = true	23 skip_install = true

39 deps =	24 deps =

40 flake8	25 flake8

41 flake8-docstrings	26 flake8-docstrings

42 flake8-commas	27 flake8-commas

43 pep8-naming	28 pep8-naming

44 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo	29 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo

45 commands =	30 commands =

46 flake8 abp	31 flake8 abp

47 flake8 --extend-ignore=D1 tests setup.py	32 flake8 --extend-ignore=D1 tests setup.py

LEFT	RIGHT