tox.ini - Issue 29968569: Issue 4014 - Publish python-abp on PyPI

Delta Between Two Patch Sets: tox.ini

Issue 29968569: Issue 4014 - Publish python-abp on PyPI (Closed) Base URL: https://hg.adblockplus.org/python-abp/

Left Patch Set: Add MANIFEST.in Created Dec. 29, 2018, 2:01 a.m.

Right Patch Set: Address comment on PS5 Created Jan. 3, 2019, 9:32 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [tox]	1 [tox]

2 envlist = py27,py35,py36,pypy,flake8	2 envlist = py27,py35,py36,pypy,flake8

3	3

4 [flake8]	4 [flake8]

5 ignore = D107, N801, W503	5 ignore = D107, N801, W503

6	6

7 [testenv]	7 [testenv]

8 deps =	8 deps =

9 pytest-cov	9 pytest-cov

10 mock	10 mock

11 commands =	11 commands =

	12 # For accurate coverage reports, we write a `pragma: no py{}` instruction

	13 # containing the current Python version to a .coveragerc file

12 python -c 'import sys; open(".coveragerc", "w").write("[report]\nexclude_lin es = pragma: no py\{\} cover".format(sys.version_info[0]))'	14 python -c 'import sys; open(".coveragerc", "w").write("[report]\nexclude_lin es = pragma: no py\{\} cover".format(sys.version_info[0]))'
Vasily Kuznetsov 2019/01/02 18:32:28 This is clever but I wonder if it would look less This is clever but I wonder if it would look less cryptic if we used `echo -e` or `printf` and environment variables instead (see https://tox.readthedocs.io/en/latest/config.html#injected-environment-variables). Something like: echo -e "[report]\nexclude_lines = pragma: no $TOX_ENV_NAME cover" >.coveragerc What do y'all think? Sebastian Noack 2019/01/02 20:42:31 There are following problems with this approach: Show quoted text On 2019/01/02 18:32:28, Vasily Kuznetsov wrote: > This is clever but I wonder if it would look less cryptic if we used `echo -e` > or `printf` and environment variables instead (see > https://tox.readthedocs.io/en/latest/config.html#injected-environment-variables). > Something like: > > echo -e "[report]\nexclude_lines = pragma: no $TOX_ENV_NAME cover" > >.coveragerc > > What do y'all think? There are following problems with this approach: 1. TOX_ENV_NAME is fairly new, it was introduced with tox 3.4. For reference, Debian Buster (currently testing / next stable) as well as Ubuntu 18.10 still come with tox 2.5. So we would have to instruct Linux users to install the latest tox version from PyPI system-wide (something I genrally don't do), or to set up a virtualenv to run tox from. IMO, this isn't worth it if it's just for this feature. 2. We don't want to mark lines to be excluded on a specific interpreter but on either Python 2 or 3. 3. We want to avoid using UNIX commands for compatibility with Windows. rhowell 2019/01/03 04:42:28 I briefly tried using tox environment variables, b Show quoted text On 2019/01/02 20:42:31, Sebastian Noack wrote: > On 2019/01/02 18:32:28, Vasily Kuznetsov wrote: > > This is clever but I wonder if it would look less cryptic if we used `echo -e` > > or `printf` and environment variables instead (see > > > https://tox.readthedocs.io/en/latest/config.html#injected-environment-variables). > > Something like: > > > > echo -e "[report]\nexclude_lines = pragma: no $TOX_ENV_NAME cover" > > >.coveragerc > > > > What do y'all think? > > There are following problems with this approach: > > 1. TOX_ENV_NAME is fairly new, it was introduced with tox 3.4. For reference, > Debian Buster (currently testing / next stable) as well as Ubuntu 18.10 still > come with tox 2.5. So we would have to instruct Linux users to install the > latest tox version from PyPI system-wide (something I genrally don't do), or to > set up a virtualenv to run tox from. IMO, this isn't worth it if it's just for > this feature. > 2. We don't want to mark lines to be excluded on a specific interpreter but on > either Python 2 or 3. > 3. We want to avoid using UNIX commands for compatibility with Windows. I briefly tried using tox environment variables, but ran into the issue that they're new with tox 3.4. Also, since we added 'Operating System :: OS Independent' to setup.py, we should try to keep it as generic as possible. But, I can add a comment so it's a bit less cryptic.
13 py.test --cov=abp --cov-report=term-missing --cov-fail-under=100 tests	15 py.test --cov=abp --cov-report=term-missing --cov-fail-under=100 tests

14	16

15 # We have to install our package in development mode so that pytest-cov can	17 # We have to install our package in development mode so that pytest-cov can

16 # find the .coverage and .coveragerc files.	18 # find the .coverage and .coveragerc files.

17 usedevelop = true	19 usedevelop = true

18	20

19 [testenv:flake8]	21 [testenv:flake8]

20 basepython = python3	22 basepython = python3

21 skip_install = true	23 skip_install = true

22 deps =	24 deps =

23 flake8	25 flake8

24 flake8-docstrings	26 flake8-docstrings

25 flake8-commas	27 flake8-commas

26 pep8-naming	28 pep8-naming

27 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo	29 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo

28 commands =	30 commands =

29 flake8 abp	31 flake8 abp

30 flake8 --extend-ignore=D1 tests setup.py	32 flake8 --extend-ignore=D1 tests setup.py

LEFT	RIGHT