Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: abp/filters/sources.py

Issue 29968569: Issue 4014 - Publish python-abp on PyPI (Closed) Base URL: https://hg.adblockplus.org/python-abp/
Patch Set: Add MANIFEST.in Created Dec. 29, 2018, 2:01 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: abp/filters/sources.py
===================================================================
--- a/abp/filters/sources.py
+++ b/abp/filters/sources.py
@@ -21,7 +21,8 @@
try:
from urllib2 import urlopen, HTTPError
-except ImportError: # The module was renamed in Python 3.
+except ImportError: # pragma: no py2 cover
+ # The module was renamed in Python 3
Sebastian Noack 2018/12/29 03:24:56 Nit: Would you agree that this comment is somewhat
Vasily Kuznetsov 2019/01/02 18:32:28 I would agree, the pragma comment seems informativ
rhowell 2019/01/03 04:42:27 Done.
from urllib.request import urlopen
from urllib.error import HTTPError

Powered by Google App Engine
This is Rietveld