Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1296)

Issue 29972568: Issue 5828 - Additional paths require settings.ini (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 2 weeks ago by rhowell
Modified:
6 months, 1 week ago
Reviewers:
Vasily Kuznetsov
CC:
juliandoucette
Base URL:
https://hg.adblockplus.org/cms/
Visibility:
Public.

Description

Issue 5828 - Additional paths require settings.ini

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments on PS1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M cms/sources.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/test_additional_paths.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5
rhowell
6 months, 2 weeks ago (2019-01-03 23:43:09 UTC) #1
Vasily Kuznetsov
Hi Rosie, Your approach works, but it introduces a side-effect of making the error message ...
6 months, 2 weeks ago (2019-01-04 18:46:03 UTC) #2
rhowell
Hey Vasily, Thanks! Let me know if you see anything else? https://codereview.adblockplus.org/29972568/diff/29972569/cms/sources.py File cms/sources.py (right): ...
6 months, 1 week ago (2019-01-08 00:19:25 UTC) #3
Vasily Kuznetsov
LGTM
6 months, 1 week ago (2019-01-08 18:45:41 UTC) #4
rhowell
6 months, 1 week ago (2019-01-08 22:27:37 UTC) #5
On 2019/01/08 18:45:41, Vasily Kuznetsov wrote:
> LGTM

Thanks, I should be able to push the changes to the repo, but now tox is failing
because of an update to Pytest. It seems it's broken compatibility with
pytest-console-scripts, and now all of the tests in test_xtm_translate.py that
use `@pytest.mark.script_launch_mode('subprocess')` are failing. For a quick
fix, I can pin pytest to the previous version in tox.ini: pytest<=4.0.2. Should
we do that? And if so, should that change be included with this?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5