Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(278)

Issue 29975555: Issue 7194 - Avoid linting old jsyhydra dependency

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 2 weeks ago by kzar
Modified:
8 months, 2 weeks ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 7194 - Avoid linting old jsyhydra dependency

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tox.ini View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
kzar
Patch Set 1 "Why not just delete the jshydra directory?" - Well, it'll keep getting ...
8 months, 2 weeks ago (2019-01-07 14:17:04 UTC) #1
Sebastian Noack
On 2019/01/07 14:17:04, kzar wrote: > Patch Set 1 > > "Why not just delete ...
8 months, 2 weeks ago (2019-01-07 22:29:33 UTC) #2
Sebastian Noack
8 months, 2 weeks ago (2019-01-07 23:29:32 UTC) #3
On 2019/01/07 22:29:33, Sebastian Noack wrote:
> I recommend to just call "hg clean" after switching between revisions,
> which will take care of deleting the the jshydra directory if any.

I just realized that unfortunately this won't work, due to
ensure_dependencies.py only adding dependencies to be ignored by version
control, leaving the ignores in place after the dependency has been removed.
Let's move this discussion to https://issues.adblockplus.org/ticket/7194.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5