Issue 7199 - Hide Recommended by Pocket from the new tab page

mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/StreamRecyclerAdapter.java

 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 20; indent-tabs-mode: nil; -*-
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 package org.mozilla.gecko.activitystream.homepanel;
 
 import android.content.Context;
 import android.content.SharedPreferences;
 import android.database.Cursor;
@@ skipping 182 matching lines @@
     public void onBindViewHolder(StreamViewHolder holder, int position) {
         int type = getItemViewType(position);
         if (type == RowItemType.HIGHLIGHT_ITEM.getViewType()) {
             final Highlight highlight = (Highlight) recyclerViewModel.get(position);
             ((WebpageItemRow) holder).bind(highlight, position, tilesSize);
         } else if (type == RowItemType.TOP_PANEL.getViewType()) {
             ((TopPanelRow) holder).bind(topSitesCursor, tilesSize);
         } else if (type == RowItemType.TOP_STORIES_ITEM.getViewType()) {
             final TopStory story = (TopStory) recyclerViewModel.get(position);
             ((WebpageItemRow) holder).bind(story, position, tilesSize);
+            // We always hide top stories by Pocket
+            // See https://issues.adblockplus.org/ticket/7199
+            setViewVisible(false, holder.itemView);
         } else if (type == RowItemType.HIGHLIGHTS_TITLE.getViewType()
                 || type == RowItemType.HIGHLIGHTS_EMPTY_STATE.getViewType()) {
             final Context context = holder.itemView.getContext();
             final SharedPreferences sharedPreferences = GeckoSharedPrefs.forProfile(context);
             final boolean bookmarksEnabled = sharedPreferences.getBoolean(ActivityStreamPanel.PREF_BOOKMARKS_ENABLED,
                     context.getResources().getBoolean(R.bool.pref_activitystream_recentbookmarks_enabled_default));
             final boolean visitedEnabled = sharedPreferences.getBoolean(ActivityStreamPanel.PREF_VISITED_ENABLED,
                     context.getResources().getBoolean(R.bool.pref_activitystream_visited_enabled_default));
             setViewVisible(bookmarksEnabled || visitedEnabled, holder.itemView);
         } else if (type == RowItemType.TOP_STORIES_TITLE.getViewType()) {
             final Context context = holder.itemView.getContext();
             final boolean pocketEnabled = ActivityStreamConfiguration.isPocketEnabledByLocale(context) &&
                     GeckoSharedPrefs.forProfile(context).getBoolean(ActivityStreamPanel.PREF_POCKET_ENABLED,
                     context.getResources().getBoolean(R.bool.pref_activitystream_pocket_enabled_default));
-            setViewVisible(pocketEnabled, holder.itemView);
+            // We always hide top stories by Pocket
+            // See https://issues.adblockplus.org/ticket/7199
+            setViewVisible(false, holder.itemView);
         }
     }
 
     /**
      * This sets a child view of the adapter visible or hidden.
      *
      * This only applies to children whose height and width are WRAP_CONTENT and MATCH_PARENT
      * respectively.
      *
      * NB: This is a hack for the views that are included in the RecyclerView adapter even if
@@ skipping 259 matching lines @@
                 || viewType == RowItemType.TOP_STORIES_ITEM.getViewType()) {
             // Highlights are always picked from recent history - So using the history id should
             // give us a unique (positive) id.
             final WebpageRowModel model = (WebpageRowModel) recyclerViewModel.get(position);
             return model.getUniqueId();
         } else {
             return recyclerViewModel.get(position).getRowItemType().stableId;
         }
     }
 }