tests/expected_output/common/en/global - Issue 29979564: Issue 5452 - Improve CMS API for local link generation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: tests/expected_output/common/en/global

Issue 29979564: Issue 5452 - Improve CMS API for local link generation (Closed) Base URL: https://hg.adblockplus.org/cms/

Patch Set: Address comments on PS1 Created Jan. 14, 2019, 2:56 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 METHOD TEST PASSEDFalseTrueexists	1 METHOD TEST PASSEDFalseTrueexistsTrueFalse
	Vasily Kuznetsov 2019/01/14 16:14:06 Let's add line breaks and maybe some descriptions Let's add line breaks and maybe some descriptions to these values, otherwise it's pretty hard to understand what's going on. Maybe like this: ... get_string('exists', 'global') = {{- get_string('exists', 'global') }} page_has_locale('global', 'en') = {{- page_has_locale('global', 'en') }} page_has_locale('global', 'de') = {{- page_has_locale('global', 'de') }} A bit repetitive, but the output would be a lot easier to examine. What do you think? rhowell 2019/01/14 16:59:33 Done. Show quoted text On 2019/01/14 16:14:06, Vasily Kuznetsov wrote: > Let's add line breaks and maybe some descriptions to these values, otherwise > it's pretty hard to understand what's going on. Maybe like this: > > ... > get_string('exists', 'global') = {{- get_string('exists', 'global') }} > page_has_locale('global', 'en') = {{- page_has_locale('global', 'en') }} > page_has_locale('global', 'de') = {{- page_has_locale('global', 'de') }} > > A bit repetitive, but the output would be a lot easier to examine. What do you > think? Done.
OLD	NEW