Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mobile/android/components/AboutRedirector.js

Issue 29981605: Issue 7211 - About Adblock Browser is opening about:firefox (Closed)
Patch Set: Created Jan. 14, 2019, 10:33 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mobile/android/components/AboutRedirector.js
===================================================================
--- a/mobile/android/components/AboutRedirector.js
+++ b/mobile/android/components/AboutRedirector.js
@@ -4,18 +4,25 @@
const Cc = Components.classes;
const Ci = Components.interfaces;
const Cu = Components.utils;
Cu.import("resource://gre/modules/AppConstants.jsm");
Cu.import("resource://gre/modules/XPCOMUtils.jsm");
var modules = {
+ // Bringing back about: module
+ // See https://issues.adblockplus.org/ticket/7211
+ "": {
+ uri: "chrome://browser/content/aboutAdblockBrowser.xhtml",
+ privileged: true
+ },
+
fennec: {
- uri: "chrome://browser/content/aboutAdblockBrowser.xhtml",
+ uri: "chrome://browser/content/about.xhtml",
privileged: true,
hide: true
},
// about:firefox is an alias for about:fennec, but not hidden from about:about
get firefox() {
return Object.assign({}, this.fennec, {hide: false});
},
@@ -69,18 +76,19 @@
accounts: {
uri: "chrome://browser/content/aboutAccounts.xhtml",
privileged: true
},
};
// Removing some about pages as part of
// https://issues.adblockplus.org/ticket/2531
-// Re-added feedback as part of https://issues.adblockplus.org/ticket/2930
-for (let moduleName of ["firefox", "fennec", "rights", "apps"])
+// Adjusted some modules as part of
+// https://issues.adblockplus.org/ticket/7211
+for (let moduleName of ["fennec", "firefox", "rights", "accounts"])
delete modules[moduleName];
function AboutRedirector() {}
AboutRedirector.prototype = {
QueryInterface: XPCOMUtils.generateQI([Ci.nsIAboutModule]),
classID: Components.ID("{322ba47e-7047-4f71-aebf-cb7d69325cd9}"),
_getModuleInfo: function(aURI) {
« no previous file with comments | « mobile/android/chrome/content/aboutAdblockBrowser.xhtml ('k') | mobile/android/themes/core/aboutPageAdblockBrowser.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld