Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: package.json

Issue 29987559: Noissue - Add "ajv" peer-dependency (Closed)
Patch Set: Created Jan. 22, 2019, 1:02 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 "name": "buildtools", 2 "name": "buildtools",
3 "repository": "https://hg.adblockplus.org/buildtools", 3 "repository": "https://hg.adblockplus.org/buildtools",
4 "license": "MPL-2.0", 4 "license": "MPL-2.0",
5 "dependencies": { 5 "dependencies": {
6 "//": [ 6 "//": [
7 "'acorn' is a peer dependency of manifoldjs, we don't use it otherwise." 7 "'acorn' and 'ajv' are peer dependencies of manifoldjs, we don't use",
kzar 2019/01/22 16:04:47 Aren't these called "transitive dependencies"?
kzar 2019/01/22 16:04:47 Did you mean to append the comma? I figure you mig
tlucas 2019/01/22 16:08:00 I did, i wanted to stick to 80 characters. for th
kzar 2019/01/22 16:12:36 Ah, gotya. Good to know, thanks.
8 " them otherwise."
8 ], 9 ],
9 "acorn": "^6.0.0", 10 "acorn": "^6.0.0",
11 "ajv": "^5.0.0",
kzar 2019/01/22 16:04:47 (I have not looked into this ajv dependency, or ch
tlucas 2019/01/22 16:08:00 Quoting cron: "npm WARN ajv-keywords@2.1.1 require
10 "jsdoc": "3.5.5", 12 "jsdoc": "3.5.5",
11 "manifoldjs": "0.7.6", 13 "manifoldjs": "0.7.6",
12 "memory-fs": "0.4.1", 14 "memory-fs": "0.4.1",
13 "webpack": "3.6.0" 15 "webpack": "3.6.0"
14 }, 16 },
15 "scripts": { 17 "scripts": {
16 "jsdoc": "jsdoc", 18 "jsdoc": "jsdoc",
17 "build-edge": "manifoldjs -l error -p edgeextension -f edgeextension -d $EXT _FOLDER -m $SRC_FOLDER/manifest.json", 19 "build-edge": "manifoldjs -l error -p edgeextension -f edgeextension -d $EXT _FOLDER -m $SRC_FOLDER/manifest.json",
18 "package-edge": "manifoldjs -l error -p edgeextension package $EXT_FOLDER/*/ edgeextension/manifest/" 20 "package-edge": "manifoldjs -l error -p edgeextension package $EXT_FOLDER/*/ edgeextension/manifest/"
19 } 21 }
20 } 22 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld